From: Andrew Morton <akpm@osdl.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, mingo@elte.hu,
christoph@lameter.com, kenneth.w.chen@intel.com
Subject: Re: [RFC][PATCH] timers fixes/improvements
Date: Sat, 2 Apr 2005 02:07:00 -0800 [thread overview]
Message-ID: <20050402020700.16221f6f.akpm@osdl.org> (raw)
In-Reply-To: <424D373F.1BCBF2AC@tv-sign.ru>
Oleg Nesterov <oleg@tv-sign.ru> wrote:
>
> +void fastcall init_timer(struct timer_list *timer)
> +{
> + timer->entry.next = NULL;
> + timer->_base = &per_cpu(tvec_bases,
> + __smp_processor_id()).t_base;
> + timer->magic = TIMER_MAGIC;
> +}
__smp_processor_id() is not implemented on all architectures. I'll switch
this to _smp_processor_id().
The smp_processor_id() stuff is all rather a twisty maze (looks at Ingo).
It's a rather odd thing which you're doing there. Why does a
not-yet-scheduled timer need a ->_base?
next prev parent reply other threads:[~2005-04-02 10:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 11:57 [RFC][PATCH] timers fixes/improvements Oleg Nesterov
2005-04-01 11:59 ` Oleg Nesterov
2005-04-01 13:07 ` Ingo Molnar
2005-04-01 13:52 ` Oleg Nesterov
2005-04-01 12:58 ` Ingo Molnar
2005-04-01 16:08 ` Linus Torvalds
2005-04-01 18:32 ` Andrew Morton
2005-04-01 18:41 ` Christoph Lameter
2005-04-01 18:44 ` Chen, Kenneth W
2005-04-02 9:22 ` Oleg Nesterov
2005-05-09 20:35 ` Christoph Lameter
2005-05-09 21:42 ` Andrew Morton
2005-05-09 21:51 ` Christoph Lameter
2005-05-10 10:23 ` Oleg Nesterov
2005-05-10 19:15 ` Christoph Lameter
2005-05-10 21:48 ` George Anzinger
2005-05-11 10:18 ` Oleg Nesterov
2005-05-11 15:12 ` Christoph Lameter
2005-05-13 22:36 ` Greg KH
[not found] ` <20050510.125301.59655362.davem@davemloft.net>
2005-05-11 15:06 ` Oleg Nesterov
2005-05-12 23:36 ` Ganesh Venkatesan
2005-05-09 23:10 ` Christoph Lameter
2005-04-02 10:07 ` Andrew Morton [this message]
2005-04-02 11:02 ` Oleg Nesterov
2005-04-02 14:58 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2005-05-17 15:38 Sy, Dely L
2005-05-17 15:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050402020700.16221f6f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox