public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@davemloft.net>,
	James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix boot hang on some architectures
Date: Sun, 3 Apr 2005 12:21:01 -0300	[thread overview]
Message-ID: <20050403152101.GC640@conectiva.com.br> (raw)
In-Reply-To: <1112471164.5786.23.camel@mulgrave>

Em Sat, Apr 02, 2005 at 01:46:03PM -0600, James Bottomley escreveu:
> Well, this is a brown paper bag for someone.  The new protocol

/me using such bag now :(

Thanks a lot for the fix.

David, Please apply.

> registration locking uses a rwlock to limit access to the protocol list.
> Unfortunately, the initialisation:
> 
> static rwlock_t proto_list_lock;
> 
> Only works to initialise the lock as unlocked on platforms whose unlock
> signal is all zeros.  On other platforms, they think it's already locked
> and hang forever.
> 
> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
> 
> 
> ===== net/core/sock.c 1.67 vs edited =====
> --- 1.67/net/core/sock.c	2005-03-26 17:04:35 -06:00
> +++ edited/net/core/sock.c	2005-04-02 13:37:20 -06:00
> @@ -1352,7 +1352,7 @@
>  
>  EXPORT_SYMBOL(sk_common_release);
>  
> -static rwlock_t proto_list_lock;
> +static DEFINE_RWLOCK(proto_list_lock);
>  static LIST_HEAD(proto_list);
>  
>  int proto_register(struct proto *prot, int alloc_slab)

  reply	other threads:[~2005-04-03 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-02 19:46 [PATCH] fix boot hang on some architectures James Bottomley
2005-04-03 15:21 ` Arnaldo Carvalho de Melo [this message]
2005-04-03 21:22   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050403152101.GC640@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox