public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Hicks <mort@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] meminfo: add Cached underflow check
Date: Mon, 4 Apr 2005 11:11:05 -0400	[thread overview]
Message-ID: <20050404151105.GG10693@localhost> (raw)


Hi,

This patch was generated against 2.6.12-rc1

Working on some code lately I've been getting huge values
for "Cached".  The cause is that get_page_cache_size() is an
approximate value, and for a sufficiently small returned value
of get_page_cache_size() the value underflows.

Signed-off-by:  Martin Hicks <mort@sgi.com>

 proc_misc.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletion(-)

Index: linux-2.6.11.cached-limit/fs/proc/proc_misc.c
===================================================================
--- linux-2.6.11.cached-limit.orig/fs/proc/proc_misc.c	2005-03-31 11:36:46.000000000 -0800
+++ linux-2.6.11.cached-limit/fs/proc/proc_misc.c	2005-03-31 11:37:12.000000000 -0800
@@ -126,6 +126,7 @@ static int meminfo_read_proc(char *page,
 	unsigned long committed;
 	unsigned long allowed;
 	struct vmalloc_info vmi;
+	unsigned long cached;
 
 	get_page_state(&ps);
 	get_zone_counts(&active, &inactive, &free);
@@ -140,6 +141,12 @@ static int meminfo_read_proc(char *page,
 	allowed = ((totalram_pages - hugetlb_total_pages())
 		* sysctl_overcommit_ratio / 100) + total_swap_pages;
 
+	cached = get_page_cache_size();
+	if (total_swapcache_pages+i.bufferram < cached)
+		cached -= total_swapcache_pages + i.bufferram;
+	else
+		cached = 0;
+
 	get_vmalloc_info(&vmi);
 
 	/*
@@ -172,7 +179,7 @@ static int meminfo_read_proc(char *page,
 		K(i.totalram),
 		K(i.freeram),
 		K(i.bufferram),
-		K(get_page_cache_size()-total_swapcache_pages-i.bufferram),
+		K(cached),
 		K(total_swapcache_pages),
 		K(active),
 		K(inactive),

             reply	other threads:[~2005-04-04 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-04 15:11 Martin Hicks [this message]
2005-04-04 22:10 ` [PATCH] meminfo: add Cached underflow check Andrew Morton
2005-04-04 22:41   ` Martin Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050404151105.GG10693@localhost \
    --to=mort@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox