Re: [RFC 5/6]clean cpu state after hotremove CPU

Zwane Mwaikambo
2005-04-04T19:12:18Z

On Mon, 4 Apr 2005, Li Shaohua wrote:

> Clean up all CPU states including its runqueue and idle thread,
> so we can use boot time code without any changes.
> Note this makes /sys/devices/system/cpu/cpux/online unworkable.
>
> #ifdef CONFIG_HOTPLUG_CPU
> #include <asm/nmi.h>
> +
> +#ifdef CONFIG_STR_SMP
> +extern void cpu_exit_clear(int);
> +#endif

Perhaps change that ifdef to denote something which clearly shows that its
physical hotplug as we'll need this for other users too.

> +#ifdef CONFIG_STR_SMP
> +extern void do_exit_idle(void);
> +extern void cpu_uninit(void);
> +void cpu_exit_clear(int cpu)
> +{
> + int sibling;
> + cpucount --;

Is that protected by the cpu_control semaphore?

Thanks,
Zwane