From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>, Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Fix u32 vs. pm_message_t in arm
Date: Mon, 4 Apr 2005 17:49:23 +0100 [thread overview]
Message-ID: <20050404174923.B12975@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050403104414.GE1357@elf.ucw.cz>; from pavel@ucw.cz on Sun, Apr 03, 2005 at 12:44:14PM +0200
On Sun, Apr 03, 2005 at 12:44:14PM +0200, Pavel Machek wrote:
> > > This fixes u32 vs. pm_message_t confusion in arm. I was not able to
> > > even compile it, but it should not cause any problems. Please apply,
> >
> > On testing this patch, it doesn't build. You need to include
> > linux/pm.h into linux/sysdev.h for starters, and fix sysdev.h
> > to also use pm_message_t in it's function pointers.
> >
> > Therefore, I'd like the following patch either to be in mainline first,
> > or in my ARM tree for Linus to pull so ARM doesn't completely break
> > on my next merge.
>
> That patch was recently merged into -mm, so I hope its okay... Thanks
> for testing. (And sorry, I did not realize patches depend on each
> other this way).
Grumble. So it hasn't been merged before the ARM changes, which means
mainline is now broken for ARM. I knew I should've just thrown it
straight in along with the stuff depending on it. ;(
Linus - is the pm.h included in sysdev.h in -rc2?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-04-04 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 19:15 Fix u32 vs. pm_message_t in arm Pavel Machek
2005-04-03 9:16 ` Russell King
2005-04-03 10:38 ` Russell King
2005-04-03 10:44 ` Pavel Machek
2005-04-04 16:49 ` Russell King [this message]
2005-04-04 17:02 ` Linus Torvalds
2005-04-04 17:05 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050404174923.B12975@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox