From: Martin Hicks <mort@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Hicks <mort@sgi.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] meminfo: add Cached underflow check
Date: Mon, 4 Apr 2005 18:41:45 -0400 [thread overview]
Message-ID: <20050404224145.GJ10693@localhost> (raw)
In-Reply-To: <20050404151049.53a30133.akpm@osdl.org>
On Mon, Apr 04, 2005 at 03:10:49PM -0700, Andrew Morton wrote:
> Martin Hicks <mort@sgi.com> wrote:
> >
> > Working on some code lately I've been getting huge values
> > for "Cached". The cause is that get_page_cache_size() is an
> > approximate value, and for a sufficiently small returned value
> > of get_page_cache_size() the value underflows.
>
> OK..
>
> I think I'd prefer to do it this way - it's simpler and the original patch
> had a teeny race wrt changes in total_swapcache_pages.
Fine by me.
mh
--
Martin Hicks || Silicon Graphics Inc. || mort@sgi.com
prev parent reply other threads:[~2005-04-04 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-04 15:11 [PATCH] meminfo: add Cached underflow check Martin Hicks
2005-04-04 22:10 ` Andrew Morton
2005-04-04 22:41 ` Martin Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050404224145.GJ10693@localhost \
--to=mort@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox