From: Pavel Machek <pavel@ucw.cz>
To: Norbert Preining <preining@logic.at>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [ACPI] Re: 2.6.12-rc1-mm4 and suspend2ram (and synaptics)
Date: Tue, 5 Apr 2005 12:06:44 +0200 [thread overview]
Message-ID: <20050405100644.GA1345@elf.ucw.cz> (raw)
In-Reply-To: <20050404081600.GA2424@gamma.logic.tuwien.ac.at>
On Po 04-04-05 10:16:00, Norbert Preining wrote:
> Hi Pavel!
>
> On Mon, 04 Apr 2005, Pavel Machek wrote:
> > I'd like to fix the problem, but first I need to know where the
> > problem is. If it works with minimal config, I know that it is one of
> > drivers you deselected.
>
> It's b44. It *was* working with b44 insmod-ed and up and running, but
> now as soon as b44-eth0 is ifup-ed while suspending, the resume freezes.
> If I do a ifdown eth0 before suspending, it works.
Does this one help?
Pavel
--- clean/drivers/net/b44.c 2005-04-05 10:55:16.000000000 +0200
+++ linux/drivers/net/b44.c 2005-04-05 10:56:33.000000000 +0200
@@ -1927,6 +1927,8 @@
b44_free_rings(bp);
spin_unlock_irq(&bp->lock);
+
+ free_irq(dev->irq, dev);
return 0;
}
@@ -1940,6 +1942,9 @@
if (!netif_running(dev))
return 0;
+ if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
+ printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name);
+
spin_lock_irq(&bp->lock);
b44_init_rings(bp);
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2005-04-05 10:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-31 22:08 2.6.12-rc1-mm4 and suspend2ram (and synaptics) Norbert Preining
2005-04-01 11:33 ` Pavel Machek
2005-04-01 17:38 ` [ACPI] " Stefan Schweizer
2005-04-02 8:59 ` Pavel Machek
2005-04-05 15:01 ` Romano Giannetti
2005-04-05 15:31 ` Rafael J. Wysocki
2005-04-03 22:45 ` Norbert Preining
2005-04-03 22:59 ` Pavel Machek
2005-04-04 8:16 ` Norbert Preining
2005-04-05 10:06 ` Pavel Machek [this message]
2005-04-05 12:46 ` Norbert Preining
2005-04-05 13:24 ` Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050405100644.GA1345@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=preining@logic.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox