Re: [PATCH 00/04] Load keyspan firmware with hotplug

Marcel Holtmann
2005-04-05T09:23:15Z

Hi Jan,

> > > > Mmm, probably that 2001 discussion about the keyspan firmware, right ?
> > > >
> > > > http://lists.debian.org/debian-legal/2001/04/msg00145.html
> > > >
> > > > Can you summarize the conclusion of the thread, or what you did get from it,
> > > > please ?
> > >
> > > That people didn't like the inclusion of firmware, I posted how you can
> > > fix it by moving it outside of the kernel, and asked for patches.
> > >
> > > None have come.
> >
> > Didn't know you were waiting for it. How about something like the
> > following series of patches?
> >
> > [01/04] - add simple Intel IHEX format parser to the firmware loader.
>
> Firmware loader is format-agnostic, I think having IHEX parser in a separate
> file would be better...

I agree with Dmitry on this point. The IHEX parser should not be inside
firmware_class.c. What about using keyspan_ihex.[ch] for it?

Regards

Marcel