From: "Theodore Ts'o" <tytso@mit.edu>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
davem@davemloft.net, shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [07/08] [TCP] Fix BIC congestion avoidance algorithm error
Date: Tue, 5 Apr 2005 14:22:02 -0400 [thread overview]
Message-ID: <20050405182202.GA11979@thunk.org> (raw)
In-Reply-To: <20050405164758.GH17299@kroah.com>
On Tue, Apr 05, 2005 at 09:47:59AM -0700, Greg KH wrote:
>
> -stable review patch. If anyone has any objections, please let us know.
>
> While redoing BIC for the split up version, I discovered that the
> existing 2.6.11 code doesn't really do binary search. It ends up
> being just a slightly modified version of Reno. See attached graphs
> to see the effect over simulated 1mbit environment.
I hate to be a stickler for the rules, but does this really meet this
criteria?
- It must fix a real bug that bothers people (not a, "This could be a
problem..." type thing.)
If the congestion control alogirthm is "Reno-like", what is
user-visible impact to users? There are OS's out there with TCP/IP
stacks that are still using Reno, aren't there?
Knowing the answer to the question, "How does this bug `bother' either
users or network administrators?" would probably be really helpful.
- Ted
next prev parent reply other threads:[~2005-04-05 18:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 16:45 [00/11] -stable review Greg KH
2005-04-05 16:46 ` [01/08] Fix Oops with ALSA timer event notification Greg KH
2005-04-05 16:46 ` [02/08] Prevent race condition in jbd Greg KH
2005-04-05 16:46 ` [03/08] fix ia64 syscall auditing Greg KH
2005-04-05 20:27 ` David Mosberger
2005-04-05 20:49 ` Greg KH
2005-04-05 21:01 ` Randy.Dunlap
2005-04-05 23:46 ` Ryan Anderson
2005-04-06 0:05 ` Greg KH
2005-04-06 0:48 ` Dave Jones
2005-04-06 22:43 ` Andrew Morton
2005-04-05 16:47 ` [04/08] I2C: Fix oops in eeprom driver Greg KH
2005-04-05 16:47 ` [05/08] [IPSEC]: Do not hold state lock while checking size Greg KH
2005-04-05 16:47 ` [06/08] rwsem fix Greg KH
2005-04-05 16:47 ` [07/08] [TCP] Fix BIC congestion avoidance algorithm error Greg KH
2005-04-05 18:22 ` Theodore Ts'o [this message]
2005-04-05 18:26 ` David S. Miller
2005-04-05 18:32 ` Stephen Hemminger
2005-04-05 16:48 ` [08/08] uml: va_copy fix Greg KH
2005-04-05 18:47 ` Renate Meijer
2005-04-05 18:53 ` Blaisorblade
2005-04-05 20:18 ` Renate Meijer
2005-04-06 11:32 ` Jörn Engel
2005-04-06 12:04 ` Renate Meijer
2005-04-06 12:27 ` Jörn Engel
2005-04-06 15:46 ` [stable] " Greg KH
2005-04-06 17:29 ` Renate Meijer
2005-04-06 17:33 ` Jörn Engel
2005-04-06 17:58 ` Renate Meijer
2005-04-06 18:13 ` Jörn Engel
2005-04-06 19:13 ` Blaisorblade
2005-04-06 19:09 ` Blaisorblade
2005-04-06 19:30 ` Jörn Engel
2005-04-07 9:16 ` Renate Meijer
2005-04-07 18:25 ` Blaisorblade
2005-04-05 17:28 ` [00/11] -stable review Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050405182202.GA11979@thunk.org \
--to=tytso@mit.edu \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox