From: Jens Axboe <axboe@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Chris Rankin <rankincj@yahoo.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler
Date: Thu, 7 Apr 2005 16:45:58 +0200 [thread overview]
Message-ID: <20050407144557.GK1847@suse.de> (raw)
In-Reply-To: <1112881183.5842.13.camel@mulgrave>
On Thu, Apr 07 2005, James Bottomley wrote:
> On Thu, 2005-04-07 at 15:32 +0200, Jens Axboe wrote:
> > I think Christophs point is that why add sdev_lock as a pointer, instead
> > of just killing it? It's only used in one location, so it's not really
> > that confusing (and a comment could fix that).
>
> Because any use of sdev->request_queue->queue_lock would likely succeed
> even after we've freed the device and released the queue. If it's a
> pointer and we null it after free and release, then any later use will
> trigger an immediate NULL deref oops.
So clear ->request_queue instead.
--
Jens Axboe
next prev parent reply other threads:[~2005-04-07 14:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 11:54 [OOPS] 2.6.11 - NMI lockup with CFQ scheduler Chris Rankin
2005-03-29 12:03 ` Jens Axboe
2005-04-06 16:27 ` James Bottomley
2005-04-06 17:58 ` Jens Axboe
2005-04-06 18:20 ` James Bottomley
2005-04-06 19:08 ` Jens Axboe
2005-04-06 21:09 ` James Bottomley
2005-04-07 6:49 ` Jens Axboe
2005-04-07 13:18 ` James Bottomley
2005-04-07 13:22 ` Christoph Hellwig
2005-04-07 13:24 ` Jens Axboe
2005-04-07 13:30 ` James Bottomley
2005-04-07 13:32 ` Jens Axboe
2005-04-07 13:39 ` James Bottomley
2005-04-07 14:45 ` Jens Axboe [this message]
2005-04-08 13:04 ` James Bottomley
2005-04-08 13:09 ` Jens Axboe
2005-04-07 13:24 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2005-03-29 12:22 Chris Rankin
2005-03-29 12:26 ` Jens Axboe
2005-04-06 12:31 ` Jens Axboe
2005-04-06 12:52 ` Arjan van de Ven
2005-04-06 12:55 ` Jens Axboe
2005-04-06 13:38 ` Tejun Heo
2005-04-06 18:01 ` Jens Axboe
2005-04-06 20:32 ` Mike Anderson
2005-03-27 19:22 Chris Rankin
2005-03-29 11:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050407144557.GK1847@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rankincj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox