Re: RFC: turn kmalloc+memset(,0,) into kcalloc

Paulo Marques
2005-04-08T16:24:47Z

Adrian Bunk wrote:
>[...]
>>>On Tue, Apr 05, 2005 at 05:26:31PM +0100, Paulo Marques wrote:
>>
>>Hi Adrian,
>
> Hi Paolo,

Paulo, please :)

Paolo is Spanish (or Italian), whereas Paulo is a Portuguese name.

>>[...]
>>I think most will agree that the second piece of code is more "readable".
>
> In this case yes (but it could still use the normal kcalloc).

Yes, but the cleanup is already just barely justifiable. 75% (or more)
of the calls will use just one parameter. Adding a stupid "1" to all of
those will make the cleanup even less worth while.

>[...]
> Joerg's list of recursions should be valid independent of the kernel
> version. Fixing any real stack problems [1] that might be in this list
> is a valuable task.
>
> And "make checkstack" in a kernel compiled with unit-at-a-time lists
> several possible problems at the top.

Ok, I've read Jörn's mail also and I think I can help out. It seems
however that there are more people working on this. Will it be better to
coordinate so we don't duplicate efforts or is the "everyone looks at
everything" approach better, so that its harder to miss something?

--
Paulo Marques - www.grupopie.com

All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)