From: Per Christian Henden <perchrh@pvv.org>
To: benh@kernel.crashing.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Add Mac mini sound support
Date: Sat, 9 Apr 2005 13:51:27 +0200 [thread overview]
Message-ID: <200504091351.27430.perchrh@pvv.org> (raw)
The patch below adds sound support on the Mac Mini by making a small change to the PowerMac sound card detection code.
Details:
Original code:
>From sound/ppc/pmac.c __init snd_pmac_detect(pmac_t *chip) :
chip->model = PMAC_AWACS;
...
if (device_is_compatible(sound, "AOAKeylargo")) {
...
chip->model = PMAC_SNAPPER;
...
}
The chip model is first set to AWACS, then because the check above returns true, it gets set to SNAPPER.
Using AWACS gives perfect sound, using SNAPPER gives no sound at all, so it should use AWACS instead.
Note that the mixer still doesn't work.
My simple patch makes the mentioned check return false on a Mac Mini.
Patch against 2.6.12-rc2:
diff -urpN -X dontdiff linux-2.6.12-rc2.orig/sound/ppc/pmac.c linux-2.6.12-rc2/sound/ppc/pmac.c
--- linux-2.6.12-rc2.orig/sound/ppc/pmac.c 2005-04-09 11:59:18.000000000 +0200
+++ linux-2.6.12-rc2/sound/ppc/pmac.c 2005-04-09 12:35:50.000000000 +0200
@@ -904,6 +904,8 @@ static int __init snd_pmac_detect(pmac_t
else if (machine_is_compatible("PowerBook1,1")
|| machine_is_compatible("AAPL,PowerBook1998"))
chip->is_pbook_G3 = 1;
+ else if (machine_is_compatible("PowerMac10,1"))
+ chip->is_macmini = 1;
chip->node = find_devices("awacs");
if (chip->node)
return 0; /* ok */
@@ -961,7 +963,7 @@ static int __init snd_pmac_detect(pmac_t
chip->freq_table = tumbler_freqs;
chip->control_mask = MASK_IEPC | 0x11; /* disable IEE */
}
- if (device_is_compatible(sound, "AOAKeylargo")) {
+ if (device_is_compatible(sound, "AOAKeylargo") && chip->is_macmini!=1) {
/* Seems to support the stock AWACS frequencies, but has
a snapper mixer */
chip->model = PMAC_SNAPPER;
diff -urpN -X dontdiff linux-2.6.12-rc2.orig/sound/ppc/pmac.h linux-2.6.12-rc2/sound/ppc/pmac.h
--- linux-2.6.12-rc2.orig/sound/ppc/pmac.h 2005-03-02 08:38:12.000000000 +0100
+++ linux-2.6.12-rc2/sound/ppc/pmac.h 2005-04-09 12:04:42.000000000 +0200
@@ -110,6 +110,7 @@ struct snd_pmac {
unsigned int has_iic : 1;
unsigned int is_pbook_3400 : 1;
unsigned int is_pbook_G3 : 1;
+ unsigned int is_macmini : 1;
unsigned int can_byte_swap : 1;
unsigned int can_duplex : 1;
-------------
The patch was tested by checking if I got sound support with the patch applied on my Mac Mini.
Thanks to Owen Stampflee at Yellowdog Linux for discovering that sound works when setting chip->model=PMAC_AWACS on the mini.
Please CC replies.
Cheers,
Per Christian Henden
next reply other threads:[~2005-04-09 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-09 11:51 Per Christian Henden [this message]
2005-04-09 23:28 ` [PATCH] Add Mac mini sound support Benjamin Herrenschmidt
2005-04-11 17:12 ` Per Christian Henden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504091351.27430.perchrh@pvv.org \
--to=perchrh@pvv.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox