* [2.6 patch] drivers/input/joystick/spaceorb.c: fix an array overflow
@ 2005-03-27 20:37 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-03-27 20:37 UTC (permalink / raw)
To: vojtech; +Cc: linux-joystick, linux-kernel
This patch fixes an array overflow found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c.old 2005-03-23 02:12:33.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c 2005-03-23 02:16:18.000000000 +0100
@@ -116,7 +116,7 @@ static void spaceorb_process_packet(stru
case 'K': /* Button data */
if (spaceorb->idx != 5) return;
- for (i = 0; i < 7; i++)
+ for (i = 0; i < 6; i++)
input_report_key(dev, spaceorb_buttons[i], (data[2] >> i) & 1);
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [2.6 patch] drivers/input/joystick/spaceorb.c: fix an array overflow
@ 2005-04-09 18:04 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-04-09 18:04 UTC (permalink / raw)
To: Andrew Morton; +Cc: vojtech, linux-joystick, linux-kernel
This patch fixes an array overflow found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 27 Mar 2005
--- linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c.old 2005-03-23 02:12:33.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c 2005-03-23 02:16:18.000000000 +0100
@@ -116,7 +116,7 @@ static void spaceorb_process_packet(stru
case 'K': /* Button data */
if (spaceorb->idx != 5) return;
- for (i = 0; i < 7; i++)
+ for (i = 0; i < 6; i++)
input_report_key(dev, spaceorb_buttons[i], (data[2] >> i) & 1);
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-04-09 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-09 18:04 [2.6 patch] drivers/input/joystick/spaceorb.c: fix an array overflow Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-03-27 20:37 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox