* [2.6 patch drivers/serial/jsm/: make 2 functions static
@ 2005-04-01 23:38 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-04-01 23:38 UTC (permalink / raw)
To: Scott_Kilau, wendyx; +Cc: linux-kernel
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/serial/jsm/jsm.h | 1 -
drivers/serial/jsm/jsm_neo.c | 2 +-
drivers/serial/jsm/jsm_tty.c | 4 +++-
3 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c.old 2005-04-02 00:20:17.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c 2005-04-02 00:20:34.000000000 +0200
@@ -688,7 +688,7 @@
/*
* No locks are assumed to be held when calling this function.
*/
-void neo_clear_break(struct jsm_channel *ch, int force)
+static void neo_clear_break(struct jsm_channel *ch, int force)
{
u64 lock_flags;
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h.old 2005-04-02 00:20:44.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h 2005-04-02 00:20:54.000000000 +0200
@@ -393,7 +393,6 @@
int jsm_uart_port_init(struct jsm_board *);
int jsm_remove_uart_port(struct jsm_board *);
void jsm_input(struct jsm_channel *ch);
-void jsm_carrier(struct jsm_channel *ch);
void jsm_check_queue_flow_control(struct jsm_channel *ch);
#endif
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c.old 2005-04-02 00:21:02.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c 2005-04-02 00:21:18.000000000 +0200
@@ -31,6 +31,8 @@
#include "jsm.h"
+static void jsm_carrier(struct jsm_channel *ch);
+
static inline int jsm_get_mstat(struct jsm_channel *ch)
{
unsigned char mstat;
@@ -760,7 +762,7 @@
jsm_printk(IOCTL, INFO, &ch->ch_bd->pci_dev, "finish\n");
}
-void jsm_carrier(struct jsm_channel *ch)
+static void jsm_carrier(struct jsm_channel *ch)
{
struct jsm_board *bd;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/serial/jsm/: make 2 functions static
@ 2005-04-09 18:04 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-04-09 18:04 UTC (permalink / raw)
To: Andrew Morton; +Cc: Scott_Kilau, linux-kernel
----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----
Date: Sat, 2 Apr 2005 01:38:51 +0200
From: Adrian Bunk <bunk@stusta.de>
To: Scott_Kilau@digi.com, wendyx@us.ltcfwd.linux.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch drivers/serial/jsm/: make 2 functions static
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 2 Apr 2005
drivers/serial/jsm/jsm.h | 1 -
drivers/serial/jsm/jsm_neo.c | 2 +-
drivers/serial/jsm/jsm_tty.c | 4 +++-
3 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c.old 2005-04-02 00:20:17.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c 2005-04-02 00:20:34.000000000 +0200
@@ -688,7 +688,7 @@
/*
* No locks are assumed to be held when calling this function.
*/
-void neo_clear_break(struct jsm_channel *ch, int force)
+static void neo_clear_break(struct jsm_channel *ch, int force)
{
u64 lock_flags;
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h.old 2005-04-02 00:20:44.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h 2005-04-02 00:20:54.000000000 +0200
@@ -393,7 +393,6 @@
int jsm_uart_port_init(struct jsm_board *);
int jsm_remove_uart_port(struct jsm_board *);
void jsm_input(struct jsm_channel *ch);
-void jsm_carrier(struct jsm_channel *ch);
void jsm_check_queue_flow_control(struct jsm_channel *ch);
#endif
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c.old 2005-04-02 00:21:02.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c 2005-04-02 00:21:18.000000000 +0200
@@ -31,6 +31,8 @@
#include "jsm.h"
+static void jsm_carrier(struct jsm_channel *ch);
+
static inline int jsm_get_mstat(struct jsm_channel *ch)
{
unsigned char mstat;
@@ -760,7 +762,7 @@
jsm_printk(IOCTL, INFO, &ch->ch_bd->pci_dev, "finish\n");
}
-void jsm_carrier(struct jsm_channel *ch)
+static void jsm_carrier(struct jsm_channel *ch)
{
struct jsm_board *bd;
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [2.6 patch] drivers/serial/jsm/: make 2 functions static
@ 2005-04-10 0:03 Kilau, Scott
0 siblings, 0 replies; 3+ messages in thread
From: Kilau, Scott @ 2005-04-10 0:03 UTC (permalink / raw)
To: Adrian Bunk, Andrew Morton; +Cc: linux-kernel
Thanks Adrian for helping clean up the driver.
Wendy will integrate your patch into our source tree.
Scott
________________________________
From: Adrian Bunk [mailto:bunk@stusta.de]
Sent: Sat 4/9/2005 1:04 PM
To: Andrew Morton
Cc: Kilau, Scott; linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/serial/jsm/: make 2 functions static
----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----
Date: Sat, 2 Apr 2005 01:38:51 +0200
From: Adrian Bunk <bunk@stusta.de>
To: Scott_Kilau@digi.com, wendyx@us.ltcfwd.linux.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch drivers/serial/jsm/: make 2 functions static
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 2 Apr 2005
drivers/serial/jsm/jsm.h | 1 -
drivers/serial/jsm/jsm_neo.c | 2 +-
drivers/serial/jsm/jsm_tty.c | 4 +++-
3 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c.old 2005-04-02 00:20:17.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c 2005-04-02 00:20:34.000000000 +0200
@@ -688,7 +688,7 @@
/*
* No locks are assumed to be held when calling this function.
*/
-void neo_clear_break(struct jsm_channel *ch, int force)
+static void neo_clear_break(struct jsm_channel *ch, int force)
{
u64 lock_flags;
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h.old 2005-04-02 00:20:44.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h 2005-04-02 00:20:54.000000000 +0200
@@ -393,7 +393,6 @@
int jsm_uart_port_init(struct jsm_board *);
int jsm_remove_uart_port(struct jsm_board *);
void jsm_input(struct jsm_channel *ch);
-void jsm_carrier(struct jsm_channel *ch);
void jsm_check_queue_flow_control(struct jsm_channel *ch);
#endif
--- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c.old 2005-04-02 00:21:02.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c 2005-04-02 00:21:18.000000000 +0200
@@ -31,6 +31,8 @@
#include "jsm.h"
+static void jsm_carrier(struct jsm_channel *ch);
+
static inline int jsm_get_mstat(struct jsm_channel *ch)
{
unsigned char mstat;
@@ -760,7 +762,7 @@
jsm_printk(IOCTL, INFO, &ch->ch_bd->pci_dev, "finish\n");
}
-void jsm_carrier(struct jsm_channel *ch)
+static void jsm_carrier(struct jsm_channel *ch)
{
struct jsm_board *bd;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-04-10 0:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-09 18:04 [2.6 patch] drivers/serial/jsm/: make 2 functions static Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-04-10 0:03 Kilau, Scott
2005-04-01 23:38 [2.6 patch " Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox