From: Andrew Morton <akpm@osdl.org>
To: "Derek Cheung" <derek.cheung@sympatico.ca>
Cc: rddunlap@osdl.org, greg@kroah.com, Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU
Date: Sun, 10 Apr 2005 16:54:12 -0700 [thread overview]
Message-ID: <20050410165412.707aca02.akpm@osdl.org> (raw)
In-Reply-To: <000801c53ded$04428920$1501a8c0@Mainframe>
"Derek Cheung" <derek.cheung@sympatico.ca> wrote:
>
> Enclosed please find the updated patch that incorporates changes for all
> the comments I received.
>
> The volatile declaration in the m528xsim.h is needed because the
> declaration refers to the ColdFire 5282 register mapping. The volatile
> declaration is actually not needed in my I2C driver but someone may
> include the m528xsim.h file in his/her applications and we need to force
> the compiler not to do any optimization on the register mapping.
- Please reissue the changelog each time you reissue a patch.
- This patch adds tons of trailing whitespace.
- It breaks the x86 build. I did this:
--- 25/drivers/i2c/busses/Kconfig~i2c-adaptor-for-coldfire-5282-cpu-fix 2005-04-10 16:52:08.000000000 -0700
+++ 25-akpm/drivers/i2c/busses/Kconfig 2005-04-10 16:52:18.000000000 -0700
@@ -31,7 +31,7 @@ config I2C_ALI1563
config I2C_MCF5282LITE
tristate "MCF5282Lite"
- depends on I2C && EXPERIMENTAL
+ depends on I2C && EXPERIMENTAL && PPC
help
If you say yes to this option, support will be included for the
I2C on the ColdFire MCF5282Lite Development Board
_
next prev parent reply other threads:[~2005-04-10 23:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050405044836.GA17336@kroah.com>
2005-04-06 2:18 ` [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU Derek Cheung
2005-04-06 2:21 ` Andrew Morton
2005-04-06 2:33 ` Derek Cheung
2005-04-06 3:10 ` Randy.Dunlap
2005-04-07 22:37 ` Matt Mackall
2005-04-07 22:42 ` [PATCH] Add dontdiff file Randy.Dunlap
2005-04-06 3:43 ` [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU Randy.Dunlap
2005-04-06 14:25 ` Greg KH
2005-04-10 16:47 ` Derek Cheung
2005-04-10 23:54 ` Andrew Morton [this message]
2005-04-11 3:32 ` Randy.Dunlap
2005-04-11 20:03 ` Greg KH
2005-04-14 1:12 ` Derek Cheung
2005-04-17 22:03 ` Greg KH
2005-04-18 21:10 ` Jean Delvare
2005-04-06 3:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050410165412.707aca02.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=derek.cheung@sympatico.ca \
--cc=greg@kroah.com \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox