public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: jes@trained-monkey.org (Jes Sorensen)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] mspec driver for 2.6.12-rc2-mm3
Date: Tue, 12 Apr 2005 03:21:08 -0700	[thread overview]
Message-ID: <20050412032108.0fa90169.akpm@osdl.org> (raw)
In-Reply-To: <16987.39773.267117.925489@jaguar.mkp.net>

jes@trained-monkey.org (Jes Sorensen) wrote:
>
> +	if (atomic_dec(&vdata->refcnt) == 0) {

atomic_dec() normally returns void.  ia64's returns int, which is a bit
risky for cross-arch developemnt.

atomic_dec_and_test() would be more conventional.

  reply	other threads:[~2005-04-12 10:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12  9:56 [patch] mspec driver for 2.6.12-rc2-mm3 Jes Sorensen
2005-04-12 10:21 ` Andrew Morton [this message]
2005-04-12 10:22 ` Andrew Morton
2005-04-12 10:27 ` Andrew Morton
2005-04-12 14:50   ` Jes Sorensen
2005-04-13 20:43     ` Christoph Hellwig
2005-04-22 11:21       ` Jes Sorensen
2005-04-24 10:16         ` Christoph Hellwig
2005-04-25 10:13           ` Jes Sorensen
2005-04-25 14:32             ` Christoph Hellwig
2005-04-25 14:41             ` efi_memmap_walk_uc, was " Christoph Hellwig
2005-04-25 14:47             ` returning non-ram via ->nopage, " Christoph Hellwig
2005-04-26 22:14               ` Jes Sorensen
2005-04-27 15:53                 ` Jeff Garzik
2005-04-27 15:55                   ` Christoph Hellwig
2005-04-27 18:03                     ` Jes Sorensen
2005-04-27 18:55                       ` Russell King
2005-05-03 20:40                 ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050412032108.0fa90169.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jes@trained-monkey.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox