Re: more git updates..

Ingo Molnar
2005-04-10T17:36:22Z

* Rik van Riel <riel@redhat.com> wrote:

> GCC 4 isn't very happy. Mostly sign changes, but also something that
> looks like a real error:
>
> gcc -g -O3 -Wall -c -o fsck-cache.o fsck-cache.c
> fsck-cache.c: In function 'main':
> fsck-cache.c:59: warning: control may reach end of non-void function 'fsck_tree' being inlined
> fsck-cache.c:62: warning: control may reach end of non-void function 'fsck_commit' being inlined
>
> I assume that fsck_tree and fsck_commit should complain loudly if they
> ever get to that point - but since I'm not quite sure there's no
> patch, sorry.

i sent a patch for most of the sign errors, but the above is a case gcc
not noticing that the function can never ever exit the loop, and thus
cannot get to the 'return' point.

Ingo