From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: nickpiggin@yahoo.com.au, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch] sched: fix active load balance
Date: Wed, 13 Apr 2005 12:07:14 -0700 [thread overview]
Message-ID: <20050413120713.A25137@unix-os.sc.intel.com> (raw)
Recent changes to active load balance (sched2-fix-smt-scheduling-problems.patch
in -mm) is not resulting in any task movement from busiest to target_cpu.
Attached patch(ontop of -mm) fixes this issue.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
--- linux-2.6.12-rc2-mm3/kernel/sched.c 2005-04-11 23:08:30.875103512 -0700
+++ linux/kernel/sched.c 2005-04-13 10:44:37.400829992 -0700
@@ -2131,7 +2131,7 @@
*/
static void active_load_balance(runqueue_t *busiest_rq, int busiest_cpu)
{
- struct sched_domain *tmp = NULL, *sd;
+ struct sched_domain *sd;
runqueue_t *target_rq;
int target_cpu = busiest_rq->push_cpu;
@@ -2152,13 +2152,10 @@
double_lock_balance(busiest_rq, target_rq);
/* Search for an sd spanning us and the target CPU. */
- for_each_domain(target_cpu, sd) {
+ for_each_domain(target_cpu, sd)
if ((sd->flags & SD_LOAD_BALANCE) &&
- cpu_isset(busiest_cpu, sd->span)) {
- sd = tmp;
+ cpu_isset(busiest_cpu, sd->span))
break;
- }
- }
if (unlikely(sd == NULL))
goto out;
next reply other threads:[~2005-04-13 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 19:07 Siddha, Suresh B [this message]
2005-04-13 20:08 ` [patch] sched: fix active load balance Ingo Molnar
2005-04-13 20:28 ` Siddha, Suresh B
2005-04-13 23:06 ` Nick Piggin
2005-04-14 7:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413120713.A25137@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox