From: Christoph Hellwig <hch@infradead.org>
To: "Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>"
<7eggert@gmx.de>
Cc: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use
Date: Wed, 13 Apr 2005 15:58:46 +0100 [thread overview]
Message-ID: <20050413145846.GA10017@infradead.org> (raw)
In-Reply-To: <E1DLfIV-0000pl-Fa@be1.7eggert.dyndns.org>
On Wed, Apr 13, 2005 at 12:40:38PM +0200, Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org> wrote:
> If there are checks, they should be there for a purpose,
emphasis here is on _should_
> and any sane reader will asume these checks to be nescensary.
That's a bad assumptions when you're deadling with drivers or software of
similar quality.
> If they are dead code, you
> can say that, but please don't flame Adrian for fixing obviously buggy code
> in a way that is sane and at least more correct than the original without
> using several days of his lifetime to analyze the whole driver. Instead, you
> could provide the correct fix.
The correct fix is to remove the check. And no, we don't have a rule that
someone must provide something better when trying to critize it.
next prev parent reply other threads:[~2005-04-13 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3SGgN-41r-1@gated-at.bofh.it>
[not found] ` <3SGA8-4n3-9@gated-at.bofh.it>
2005-04-13 10:40 ` [2.6 patch] sound/oss/rme96xx.c: fix two check after use Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>
2005-04-13 14:58 ` Christoph Hellwig [this message]
2005-04-13 17:46 ` Al Viro
2005-04-13 2:17 Adrian Bunk
2005-04-13 3:03 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2005-03-27 21:17 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413145846.GA10017@infradead.org \
--to=hch@infradead.org \
--cc=7eggert@gmx.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox