Re: Re: [ANNOUNCE] git-pasky-0.3

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Wed, Apr 13, 2005 at 09:13:39PM +0200, Petr Baudis wrote:
> Dear diary, on Wed, Apr 13, 2005 at 09:03:07PM CEST, I got a letter
> where Russell King <rmk+lkml@arm.linux.org.uk> told me that...
> > On Wed, Apr 13, 2005 at 10:35:21AM +0100, Russell King wrote:
> > > I tried this today, applied my patch for BE<->LE conversions and
> > > glibc-2.2 compatibility (attached, still requires cleaning though),
> > > and then tried git pull.  Umm, whoops.
> > 
> > Here's an updated patch which allows me to work with a BE-based
> > cache.  I've just used this to grab and checkout sparse.git.
> > 
> > Note: it also fixes my glibc-2.2 build problem with the nsec
> > stat64 structures (see read-cache.c).
> > 
> > --- cache.h
> > +++ cache.h	Wed Apr 13 11:23:39 2005
> > @@ -14,6 +14,12 @@
> >  #include <openssl/sha.h>
> >  #include <zlib.h>
> >  
> > +#include <netinet/in.h>
> > +#define cpu_to_beuint(x)	(htonl(x))
> > +#define beuint_to_cpu(x)	(ntohl(x))
> > +#define cpu_to_beushort(x)	(htons(x))
> > +#define beushort_to_cpu(x)	(ntohs(x))
> > +
> >  /*
> >   * Basic data structures for the directory cache
> >   *
> 
> What do the wrapper macros gain us?

Nothing much - I don't particularly care about them.  I thought someone
might object to using htonl/ntohl directly.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core