* [2.6 patch] unexport panic_timeout
@ 2005-04-15 15:10 Adrian Bunk
2005-04-23 23:56 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-04-15 15:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any possible modular usage in the kernel.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 4 Mar 2005
--- linux-2.6.11-rc5-mm1-full/kernel/panic.c.old 2005-03-04 00:54:46.000000000 +0100
+++ linux-2.6.11-rc5-mm1-full/kernel/panic.c 2005-03-04 00:54:54.000000000 +0100
@@ -24,8 +24,6 @@
int panic_on_oops;
int tainted;
-EXPORT_SYMBOL(panic_timeout);
-
struct notifier_block *panic_notifier_list;
EXPORT_SYMBOL(panic_notifier_list);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] unexport panic_timeout
2005-04-15 15:10 [2.6 patch] unexport panic_timeout Adrian Bunk
@ 2005-04-23 23:56 ` Andrew Morton
2005-05-02 1:46 ` [2.6 patch] __deprecated_for_modules panic_timeout Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-04-23 23:56 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any possible modular usage in the kernel.
>
panic_timeout has many in-kernel users and it is used from within a module
in 2.4.30.
Hence it is easily possible that some out-of-tree code is dependent upon
this export, hence I shan't be applying this patch.
>
> --- linux-2.6.11-rc5-mm1-full/kernel/panic.c.old 2005-03-04 00:54:46.000000000 +0100
> +++ linux-2.6.11-rc5-mm1-full/kernel/panic.c 2005-03-04 00:54:54.000000000 +0100
> @@ -24,8 +24,6 @@
> int panic_on_oops;
> int tainted;
>
> -EXPORT_SYMBOL(panic_timeout);
> -
> struct notifier_block *panic_notifier_list;
>
> EXPORT_SYMBOL(panic_notifier_list);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] __deprecated_for_modules panic_timeout
2005-04-23 23:56 ` Andrew Morton
@ 2005-05-02 1:46 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-05-02 1:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sat, Apr 23, 2005 at 04:56:09PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > I didn't find any possible modular usage in the kernel.
> >
>
> panic_timeout has many in-kernel users and it is used from within a module
> in 2.4.30.
>
> Hence it is easily possible that some out-of-tree code is dependent upon
> this export, hence I shan't be applying this patch.
Patch to deprecate it is below.
cu
Adrian
<-- snip -->
--- linux-2.6.12-rc3-mm2-full/Documentation/feature-removal-schedule.txt.old 2005-05-02 00:03:06.000000000 +0200
+++ linux-2.6.12-rc3-mm2-full/Documentation/feature-removal-schedule.txt 2005-05-02 00:03:52.000000000 +0200
@@ -65,0 +66,8 @@
+
+---------------------------
+
+What: remove EXPORT_SYMBOL(panic_timeout)
+When: April 2006
+Files: kernel/panic.c
+Why: No modular usage in the kernel.
+Who: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc3-mm2-full/include/linux/kernel.h.old 2005-05-02 00:04:02.000000000 +0200
+++ linux-2.6.12-rc3-mm2-full/include/linux/kernel.h 2005-05-02 00:04:22.000000000 +0200
@@ -163 +163 @@
-extern int panic_timeout;
+extern __deprecated_for_modules int panic_timeout;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-02 1:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-15 15:10 [2.6 patch] unexport panic_timeout Adrian Bunk
2005-04-23 23:56 ` Andrew Morton
2005-05-02 1:46 ` [2.6 patch] __deprecated_for_modules panic_timeout Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox