public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Hariprasad Nellitheertha <hari@in.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][x86_64] Introducing the memmap= kernel command line option
Date: 15 Apr 2005 19:30:40 +0200
Date: Fri, 15 Apr 2005 19:30:40 +0200	[thread overview]
Message-ID: <20050415173040.GK50241@muc.de> (raw)
In-Reply-To: <425F5BA3.3050001@in.ibm.com>

On Fri, Apr 15, 2005 at 11:43:55AM +0530, Hariprasad Nellitheertha wrote:
> Hi Andi,
> 
> In order to port kdump to x86_64, we need to have the 
> memmap= kernel command line option available. This is so 
> that the dump-capture kernel can be booted with a custom 
> memory map.
> 
> The attached patch adds the memmap= functionality to the 
> x86_64 kernel. It is against 2.6.12-rc2-mm3. I have done 
> some amount of testing and it is working fine.
> 
> Could you kindly review this patch and let me know your 
> thoughts on it.

You should add a __setup somewhere, otherwise the kernel
will complain about unknown arguments or generate a memmap
variable in inits environment. 

Comma parsing would be nice.

Otherwise it looks ok.

-Andi

  reply	other threads:[~2005-04-15 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-15  6:13 [RFC][x86_64] Introducing the memmap= kernel command line option Hariprasad Nellitheertha
2005-04-15 17:30 ` Andi Kleen [this message]
2005-04-18 12:47   ` Hariprasad Nellitheertha
2005-04-28 10:59   ` Hariprasad Nellitheertha
2005-04-28 11:00     ` [RFC][i386] Comma parsing for " Hariprasad Nellitheertha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050415173040.GK50241@muc.de \
    --to=ak@muc.de \
    --cc=hari@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox