From: Greg KH <greg@kroah.com>
To: Kylene Hall <kjhall@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH] tpm: Stop taking over the non-unique lpc bus PCI ID, Also timer, stack and enum fixes
Date: Fri, 15 Apr 2005 16:52:50 -0700 [thread overview]
Message-ID: <20050415235250.GA24204@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504151611390.24192@dyn95395164>
On Fri, Apr 15, 2005 at 05:06:06PM -0500, Kylene Hall wrote:
> This patch is against the 2.6.12-rc2 kernel source. It changes the tpm
> drivers from defining a pci driver structure to a format similar to the
> drivers/char/watchdog/i8xx_tco driver. This is necessary because the
> lpc_bus only has one PCI ID and claiming that ID in the pci driver probe
> process prevents other drivers from finding their hardware.
NO! DO NOT use pci_find_device(). It is broken for systems with pci
hotplug (which means any pci system). Please use the way the driver
currently works, that is correct.
> This patch
> also fixes numerous problems that were pointed out with timer
> manipulations, large stack objects, lack of enums and defined constants.
Why not split these up into the proper individual patches? Remember,
one patch per "change".
> Still lingering:
>
> How can I receive Hotplug and ACPI events without being a PCI driver?
You can't, so don't.
thanks,
greg k-h
next prev parent reply other threads:[~2005-04-15 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 22:06 [PATCH] tpm: Stop taking over the non-unique lpc bus PCI ID, Also timer, stack and enum fixes Kylene Hall
2005-04-15 23:52 ` Greg KH [this message]
2005-04-17 0:05 ` Dave Airlie
2005-04-17 21:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050415235250.GA24204@kroah.com \
--to=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox