Re: [RFC][PATCH 4/4] AES assembler implementation for x86_64

[Adrian Bunk <bunk@stusta.de>]

On Sun, Apr 17, 2005 at 09:20:21PM +0200, Andreas Steinmetz wrote:

> The attached patch contains the required changes for the crypto Kconfig
> to enable the usage of the x86_64 AES assembler implementation.


That is not specifically against this patch, but before we add another 
AES implementation, I'd like to find a better solution for the general 
AES selection.

My original thoughts on this issue are in [1], but this didn't attack 
the problem of CRYPTO_DEV_PADLOCK_AES where it might not be known at 
compile time whether the hardware will be present.


> Andreas Steinmetz

> diff -rNu linux-2.6.11.2.orig/crypto/Kconfig linux-2.6.11.2/crypto/Kconfig
> --- linux-2.6.11.2.orig/crypto/Kconfig	2005-03-09 09:12:53.000000000 +0100
> +++ linux-2.6.11.2/crypto/Kconfig	2005-04-17 13:10:51.000000000 +0200
>...
>  config CRYPTO_AES_586
>  	tristate "AES cipher algorithms (i586)"
> -	depends on CRYPTO && (X86 && !X86_64)
> +	depends on CRYPTO && X86 && !X86_64
>...

This doesn't make any difference.

I think the former version was better readable, but that's no strong 
opinion.

cu
Adrian

[1] http://www.ussg.iu.edu/hypermail/linux/kernel/0502.3/0518.html

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed