From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/char/mwave/3780i.c: cleanups
Date: Sun, 17 Apr 2005 22:09:26 +0200 [thread overview]
Message-ID: <20050417200926.GL3625@stusta.de> (raw)
This patch contains the following cleanups:
- make a needlessly global function static
- #if 0 the unused global function dsp3780I_ReadGenCfg
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/char/mwave/3780i.c | 6 ++++--
drivers/char/mwave/3780i.h | 4 ----
2 files changed, 4 insertions(+), 6 deletions(-)
--- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h.old 2005-04-17 18:12:29.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h 2005-04-17 18:13:16.000000000 +0200
@@ -338,10 +338,6 @@
unsigned long ulMsaAddr);
void dsp3780I_WriteMsaCfg(unsigned short usDspBaseIO,
unsigned long ulMsaAddr, unsigned short usValue);
-void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
- unsigned char ucValue);
-unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
- unsigned uIndex);
int dsp3780I_GetIPCSource(unsigned short usDspBaseIO,
unsigned short *pusIPCSource);
--- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c.old 2005-04-17 18:12:49.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c 2005-04-17 18:13:33.000000000 +0200
@@ -107,8 +107,8 @@
spin_unlock_irqrestore(&dsp_lock, flags);
}
-void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
- unsigned char ucValue)
+static void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
+ unsigned char ucValue)
{
DSP_ISA_SLAVE_CONTROL rSlaveControl;
DSP_ISA_SLAVE_CONTROL rSlaveControl_Save;
@@ -141,6 +141,7 @@
}
+#if 0
unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
unsigned uIndex)
{
@@ -167,6 +168,7 @@
return ucValue;
}
+#endif /* 0 */
int dsp3780I_EnableDSP(DSP_3780I_CONFIG_SETTINGS * pSettings,
unsigned short *pIrqMap,
next reply other threads:[~2005-04-17 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-17 20:09 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-30 20:08 [2.6 patch] drivers/char/mwave/3780i.c: cleanups Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050417200926.GL3625@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox