public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dave Airlie <airlied@gmail.com>
Cc: Kylene Hall <kjhall@us.ibm.com>,
	linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH] tpm: Stop taking over the non-unique lpc bus PCI ID, Also timer, stack and enum fixes
Date: Sun, 17 Apr 2005 14:58:51 -0700	[thread overview]
Message-ID: <20050417215850.GA3178@kroah.com> (raw)
In-Reply-To: <21d7e9970504161705a129893@mail.gmail.com>

On Sun, Apr 17, 2005 at 10:05:27AM +1000, Dave Airlie wrote:
> > NO!  DO NOT use pci_find_device().  It is broken for systems with pci
> > hotplug (which means any pci system).  Please use the way the driver
> > currently works, that is correct.
> 
> But its not an LPC driver, it only uses a small piece of the LPC, we
> really do need some sort of bridge driver layer or something for
> these, then other drivers can sit on top of that,

Then the TPM driver can provide that layer.

> The DRM still uses pci_find_device for the exact same reason, the fb
> drivers take the PCI device and we have been told we can't use the
> proper interface, hence one of the needs to merge fb and DRM..

Exactly.

thanks,

greg k-h

      reply	other threads:[~2005-04-17 23:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-15 22:06 [PATCH] tpm: Stop taking over the non-unique lpc bus PCI ID, Also timer, stack and enum fixes Kylene Hall
2005-04-15 23:52 ` Greg KH
2005-04-17  0:05   ` Dave Airlie
2005-04-17 21:58     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050417215850.GA3178@kroah.com \
    --to=greg@kroah.com \
    --cc=airlied@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=kjhall@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox