From: Adrian Bunk <bunk@stusta.de>
To: 2003 John Klar <linpvr@projectplasma.com>
Cc: linux-kernel@vger.kernel.org, kraxel@bytesex.org,
video4linux-list@redhat.com
Subject: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
Date: Tue, 19 Apr 2005 02:53:15 +0200 [thread overview]
Message-ID: <20050419005315.GP5489@stusta.de> (raw)
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/video/tveeprom.c | 6 ++++--
include/media/tveeprom.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19 01:41:24.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19 01:41:28.000000000 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old 2005-04-19 01:40:39.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c 2005-04-19 01:41:13.000000000 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* ----------------------------------------------------------------------- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
next reply other threads:[~2005-04-19 0:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 0:53 Adrian Bunk [this message]
2005-04-19 7:53 ` [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups Gerd Knorr
2005-05-01 14:23 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-07-09 3:07 Adrian Bunk
2005-07-15 21:35 Adrian Bunk
2005-07-15 22:29 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419005315.GP5489@stusta.de \
--to=bunk@stusta.de \
--cc=kraxel@bytesex.org \
--cc=linpvr@projectplasma.com \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox