From: Andrey Panin <pazke@donpac.ru>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] i386: cleanup boot_cpu_logical_apicid variables
Date: Tue, 19 Apr 2005 13:55:43 +0400 [thread overview]
Message-ID: <20050419095543.GA10555@pazke> (raw)
In-Reply-To: <20050415143529.GC5456@stusta.de>
On 105, 04 15, 2005 at 04:35:29PM +0200, Adrian Bunk wrote:
> There are currently two different boot_cpu_logical_apicid variables:
> - a global one in mpparse.c
> - a static one in smpboot.c
>
> Of these two, only the one in smpboot.c might be used (through
> boot_cpu_apicid).
>
> This patch therefore removes the one in mpparse.c .
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Looks good. For the visws part:
Signed-off-by: Andrey Panin <pazke@donpac.ru>
> ---
>
> arch/i386/kernel/mpparse.c | 2 --
> arch/i386/mach-visws/mpparse.c | 5 +----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> --- linux-2.6.12-rc2-mm3-full/arch/i386/kernel/mpparse.c.old 2005-04-15 14:21:41.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/arch/i386/kernel/mpparse.c 2005-04-15 14:22:00.000000000 +0200
> @@ -67,7 +67,6 @@
>
> /* Processor that is doing the boot up */
> unsigned int boot_cpu_physical_apicid = -1U;
> -unsigned int boot_cpu_logical_apicid = -1U;
> /* Internal processor count */
> static unsigned int __initdata num_processors;
>
> @@ -180,7 +179,6 @@
> if (m->mpc_cpuflag & CPU_BOOTPROCESSOR) {
> Dprintk(" Bootup CPU\n");
> boot_cpu_physical_apicid = m->mpc_apicid;
> - boot_cpu_logical_apicid = apicid;
> }
>
> if (num_processors >= NR_CPUS) {
> --- linux-2.6.12-rc2-mm3-full/arch/i386/mach-visws/mpparse.c.old 2005-04-15 14:22:10.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/arch/i386/mach-visws/mpparse.c 2005-04-15 14:22:27.000000000 +0200
> @@ -23,7 +23,6 @@
>
> /* Processor that is doing the boot up */
> unsigned int boot_cpu_physical_apicid = -1U;
> -unsigned int boot_cpu_logical_apicid = -1U;
>
> /* Bitmask of physically existing CPUs */
> physid_mask_t phys_cpu_present_map;
> @@ -52,10 +51,8 @@
> (m->mpc_cpufeature & CPU_MODEL_MASK) >> 4,
> m->mpc_apicver);
>
> - if (m->mpc_cpuflag & CPU_BOOTPROCESSOR) {
> + if (m->mpc_cpuflag & CPU_BOOTPROCESSOR)
> boot_cpu_physical_apicid = m->mpc_apicid;
> - boot_cpu_logical_apicid = logical_apicid;
> - }
>
> ver = m->mpc_apicver;
> if ((ver >= 0x14 && m->mpc_apicid >= 0xff) || m->mpc_apicid >= 0xf) {
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Andrey Panin | Linux and UNIX system administrator
pazke@donpac.ru | PGP key: wwwkeys.pgp.net
next prev parent reply other threads:[~2005-04-19 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 14:35 [2.6 patch] i386: cleanup boot_cpu_logical_apicid variables Adrian Bunk
2005-04-19 9:55 ` Andrey Panin [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-02 1:47 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419095543.GA10555@pazke \
--to=pazke@donpac.ru \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox