From: Johannes Stezenbach <js@linuxtv.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-dvb-maintainer] [2.6 patch] drivers/media/dvb/: possible cleanups
Date: Wed, 20 Apr 2005 20:15:45 +0200 [thread overview]
Message-ID: <20050420181545.GA4876@linuxtv.org> (raw)
In-Reply-To: <20050419004308.GJ5489@stusta.de>
On Tue, Apr 19, 2005 at 02:43:08AM +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global functions:
> - dibusb/dvb-dibusb-usb.c: dibusb_set_streaming_mode
> - frontends/mt352.c: mt352_read
> - ttpci/av7110_hw.c: av7110_reset_arm
> - ttpci/av7110_hw.c: av7110_send_ci_cmd
> - remove the following unneeded EXPORT_SYMBOL:
> - frontends/mt352.c: mt352_read
>
> Please review which of these changes do make sense.
I'll apply this patch to linuxtv.org CVS.
Most cleanups look fine, except the dibusb driver
has been superseded by a generalized dvb-usb driver.
mt352_read() can be dropped completely.
Thanks,
Johannes
prev parent reply other threads:[~2005-04-20 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 0:43 [2.6 patch] drivers/media/dvb/: possible cleanups Adrian Bunk
2005-04-20 18:15 ` Johannes Stezenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050420181545.GA4876@linuxtv.org \
--to=js@linuxtv.org \
--cc=bunk@stusta.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox