From: Ralf Baechle <ralf@linux-mips.org>
To: Domen Puncer <domen@coderock.org>
Cc: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>,
vda@port.imtp.ilyichevsk.odessa.ua, linux-kernel@vger.kernel.org,
mpm@selenic.com
Subject: Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version
Date: Wed, 20 Apr 2005 21:47:07 +0100 [thread overview]
Message-ID: <20050420204707.GC4551@linux-mips.org> (raw)
In-Reply-To: <20050419202037.GE21272@nd47.coderock.org>
On Tue, Apr 19, 2005 at 10:20:38PM +0200, Domen Puncer wrote:
> > Please keep using __inline__, not inline.
>
> Why?
>
> Couldn't find any threads about this, and even SubmittingPatches has:
> "'static inline' is preferred over 'static __inline__'..."
Unlike inline __inline__ will be recogniced by gcc even in -ansi mode.
And inline is namespace pollution. Where there's no technical reason I
prefer the non-underscore version, __inline__ is just looking too 1337
and eye-insulting.
Of course all these thoughts are useless because these days usespace is
not supposed to use kernel headers directly and the kernel isn't ANSI-clean
anyway.
Ralf
next prev parent reply other threads:[~2005-04-21 10:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 6:18 [PATCH] introduce generic 64bit rotations and i386 asm optimized version Denis Vlasenko
2005-04-19 6:21 ` [PATCH] sha512: replace open-coded be64 conversions Denis Vlasenko
2005-04-19 6:26 ` [PATCH] sha512: use 64bit rotations Denis Vlasenko
2005-04-19 6:28 ` [PATCH] sha512: fix whitespace Denis Vlasenko
2005-04-19 6:31 ` [PATCH] ia64: use 64bit rotations Denis Vlasenko
2005-04-19 9:04 ` [PATCH] sha512: replace open-coded be64 conversions Jesper Juhl
2005-04-19 14:12 ` Denis Vlasenko
2005-04-19 14:41 ` Jesper Juhl
2005-04-19 14:49 ` Denis Vlasenko
2005-04-19 6:46 ` [PATCH] introduce generic 64bit rotations and i386 asm optimized version YOSHIFUJI Hideaki / 吉藤英明
2005-04-19 6:55 ` Denis Vlasenko
2005-04-19 20:20 ` Domen Puncer
2005-04-20 20:47 ` Ralf Baechle [this message]
2005-04-19 19:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050420204707.GC4551@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox