public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] correct the DEBUG_BUGVERBOSE question dependency
Date: Sat, 23 Apr 2005 03:20:35 +0200	[thread overview]
Message-ID: <20050423012035.GR4355@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0504230302400.863@scrub.home>

On Sat, Apr 23, 2005 at 03:05:17AM +0200, Roman Zippel wrote:
> Hi,
> 
> On Sat, 23 Apr 2005, Adrian Bunk wrote:
> 
> > Currently, DEBUG_BUGVERBOSE, is automatically set to "y" if 
> > DEBUG_KERNEL=n and EMBEDDED=y which doesn't make much sense.
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> > --- linux-2.6.12-rc2-mm3-full/lib/Kconfig.debug.old	2005-04-22 03:03:27.000000000 +0200
> > +++ linux-2.6.12-rc2-mm3-full/lib/Kconfig.debug	2005-04-22 03:04:00.000000000 +0200
> > @@ -125,9 +125,9 @@
> >  	  This options enables addition error checking for high memory systems.
> >  	  Disable for production systems.
> >  
> >  config DEBUG_BUGVERBOSE
> > -	bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EMBEDDED
> > +	bool "Verbose BUG() reporting (adds 70K)" if EMBEDDED
> >  	depends on BUG
> >  	depends on ARM || ARM26 || M32R || M68K || SPARC32 || SPARC64 || (X86 && !X86_64) || FRV
> >  	default !EMBEDDED
> >  	help
> 
> 1. you just messed up the menu structure.
> 2. the default is "!EMBEDDED", so it should become "n"?!


Ups, thanks for the correction.

I didn't see this, and this makes my patch completely pointless.


> bye, Roman

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2005-04-23  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-23  0:25 [2.6 patch] correct the DEBUG_BUGVERBOSE question dependency Adrian Bunk
2005-04-23  1:05 ` Roman Zippel
2005-04-23  1:20   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050423012035.GR4355@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox