From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [2.6 patch] unexport is_console_locked
Date: Sat, 23 Apr 2005 16:49:48 -0700 [thread overview]
Message-ID: <20050423164948.652cc82b.akpm@osdl.org> (raw)
In-Reply-To: <20050415151045.GK5456@stusta.de>
Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any possible modular usage in the kernel.
>
Is needed for WARN_CONSOLE_UNLOCKED().
It just happens that WARN_CONSOLE_UNLOCKED() is currently only using in
vt.c, which just happens to not support modular usage.
But disabling this export would make WARN_CONSOLE_UNLOCKED() pretty useless
for driver development.
So I'd suggest that we either leave this symbol exported for driver
developers or we nuke WARN_CONSOLE_UNLOCKED() altogether.
Ben, do you still want it?
> --- linux-2.6.11-rc5-mm1-full/kernel/printk.c.old 2005-03-04 00:58:16.000000000 +0100
> +++ linux-2.6.11-rc5-mm1-full/kernel/printk.c 2005-03-04 00:58:22.000000000 +0100
> @@ -675,7 +675,6 @@
> {
> return console_locked;
> }
> -EXPORT_SYMBOL(is_console_locked);
>
> /**
> * release_console_sem - unlock the console system
next prev parent reply other threads:[~2005-04-23 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 15:10 [2.6 patch] unexport is_console_locked Adrian Bunk
2005-04-23 23:49 ` Andrew Morton [this message]
2005-04-24 0:51 ` Benjamin Herrenschmidt
2005-04-24 9:54 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2005-03-04 0:48 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050423164948.652cc82b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox