From: Christoph Hellwig <hch@infradead.org>
To: Jes Sorensen <jes@wildopensource.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] mspec driver for 2.6.12-rc2-mm3
Date: Mon, 25 Apr 2005 15:32:11 +0100 [thread overview]
Message-ID: <20050425143211.GA9902@infradead.org> (raw)
In-Reply-To: <yq03btftb9u.fsf@jaguar.mkp.net>
On Mon, Apr 25, 2005 at 06:13:01AM -0400, Jes Sorensen wrote:
> >>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>
> >> The code use the size to calculate, it could be changed either
> >> way, don't think it's worth making the change.
>
> Christoph> The current code is obsufcated, see the pages-1 stuff and
> Christoph> co. Please change it.
>
> Both ways work, this is down to nitpicking for the sake of
> nitpicking. Whatever, I'll change it.
It's nitpicking to keep the code readable. Same thing as always using
named initializers for method vectors or similar things.
next prev parent reply other threads:[~2005-04-25 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 9:56 [patch] mspec driver for 2.6.12-rc2-mm3 Jes Sorensen
2005-04-12 10:21 ` Andrew Morton
2005-04-12 10:22 ` Andrew Morton
2005-04-12 10:27 ` Andrew Morton
2005-04-12 14:50 ` Jes Sorensen
2005-04-13 20:43 ` Christoph Hellwig
2005-04-22 11:21 ` Jes Sorensen
2005-04-24 10:16 ` Christoph Hellwig
2005-04-25 10:13 ` Jes Sorensen
2005-04-25 14:32 ` Christoph Hellwig [this message]
2005-04-25 14:41 ` efi_memmap_walk_uc, was " Christoph Hellwig
2005-04-25 14:47 ` returning non-ram via ->nopage, " Christoph Hellwig
2005-04-26 22:14 ` Jes Sorensen
2005-04-27 15:53 ` Jeff Garzik
2005-04-27 15:55 ` Christoph Hellwig
2005-04-27 18:03 ` Jes Sorensen
2005-04-27 18:55 ` Russell King
2005-05-03 20:40 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050425143211.GA9902@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=jes@wildopensource.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox