From: Jeff Dike <jdike@addtoit.com>
To: blaisorblade@yahoo.it
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, axboe@suse.de
Subject: Re: [patch 1/1] uml ubd: handle readonly status
Date: Mon, 25 Apr 2005 17:34:48 -0400 [thread overview]
Message-ID: <20050425213448.GA6343@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20050425191949.E56D145EBB@zion>
On Mon, Apr 25, 2005 at 09:19:49PM +0200, blaisorblade@yahoo.it wrote:
> + /* This should no more be needed. And it didn't work anyway to exclude
> + * read-write remounting of filesystems.*/
> + /*if((filp->f_mode & FMODE_WRITE) && !dev->openflags.w){
> if(--dev->count == 0) ubd_close(dev);
> err = -EROFS;
> - }
> + }*/
> + /* This should be impossible now */
> + /* This should be impossible now */
If code can't run any more because of now-impossible conditions, then just
delete it.
Jeff
prev parent reply other threads:[~2005-04-25 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 19:19 [patch 1/1] uml ubd: handle readonly status blaisorblade
2005-04-25 21:34 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050425213448.GA6343@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox