[2.6 patch] unexport __print_symbol

[2.6 patch] unexport __print_symbol

[Adrian Bunk]

I didn't find any possible modular usage in the kernel.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c.old	2005-03-04 00:49:34.000000000 +0100
+++ linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c	2005-03-04 00:49:49.000000000 +0100
@@ -408,4 +408,3 @@
 }
 __initcall(kallsyms_init);
 
-EXPORT_SYMBOL(__print_symbol);

[2.6 patch] unexport __print_symbol

[Adrian Bunk]

I didn't find any possible modular usage in the kernel.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 4 Mar 2005

--- linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c.old	2005-03-04 00:49:34.000000000 +0100
+++ linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c	2005-03-04 00:49:49.000000000 +0100
@@ -408,4 +408,3 @@
 }
 __initcall(kallsyms_init);
 
-EXPORT_SYMBOL(__print_symbol);

Re: [2.6 patch] unexport __print_symbol

[Andrew Morton]

Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any possible modular usage in the kernel.
> 

Making print_symbol() available to modules during their development might
aid that development.  Presumably, such debug code would not appear in the
mainline tree.

IOW: people might want to use print_symbol() during private development, so
we should continue to export it to modules.


> 
> --- linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c.old	2005-03-04 00:49:34.000000000 +0100
> +++ linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c	2005-03-04 00:49:49.000000000 +0100
> @@ -408,4 +408,3 @@
>  }
>  __initcall(kallsyms_init);
>  
> -EXPORT_SYMBOL(__print_symbol);

Re: [2.6 patch] unexport __print_symbol

[Adrian Bunk]

On Sat, Apr 23, 2005 at 04:35:18PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > I didn't find any possible modular usage in the kernel.
> > 
> 
> Making print_symbol() available to modules during their development might
> aid that development.  Presumably, such debug code would not appear in the
> mainline tree.
> 
> IOW: people might want to use print_symbol() during private development, so
> we should continue to export it to modules.

If you need it during private development, you can always re-add it in 
your private tree.

And the possibility of such debug code accidentially getting into 
mainline drops to zero if the EXPORT_SYMBOL isn't there.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed