* [2.6 patch] unexport __print_symbol
@ 2005-04-15 15:10 Adrian Bunk
2005-04-23 23:35 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-04-15 15:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any possible modular usage in the kernel.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 4 Mar 2005
--- linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c.old 2005-03-04 00:49:34.000000000 +0100
+++ linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c 2005-03-04 00:49:49.000000000 +0100
@@ -408,4 +408,3 @@
}
__initcall(kallsyms_init);
-EXPORT_SYMBOL(__print_symbol);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] unexport __print_symbol
2005-04-15 15:10 [2.6 patch] unexport __print_symbol Adrian Bunk
@ 2005-04-23 23:35 ` Andrew Morton
2005-04-25 23:02 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2005-04-23 23:35 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any possible modular usage in the kernel.
>
Making print_symbol() available to modules during their development might
aid that development. Presumably, such debug code would not appear in the
mainline tree.
IOW: people might want to use print_symbol() during private development, so
we should continue to export it to modules.
>
> --- linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c.old 2005-03-04 00:49:34.000000000 +0100
> +++ linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c 2005-03-04 00:49:49.000000000 +0100
> @@ -408,4 +408,3 @@
> }
> __initcall(kallsyms_init);
>
> -EXPORT_SYMBOL(__print_symbol);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] unexport __print_symbol
2005-04-23 23:35 ` Andrew Morton
@ 2005-04-25 23:02 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-04-25 23:02 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sat, Apr 23, 2005 at 04:35:18PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > I didn't find any possible modular usage in the kernel.
> >
>
> Making print_symbol() available to modules during their development might
> aid that development. Presumably, such debug code would not appear in the
> mainline tree.
>
> IOW: people might want to use print_symbol() during private development, so
> we should continue to export it to modules.
If you need it during private development, you can always re-add it in
your private tree.
And the possibility of such debug code accidentially getting into
mainline drops to zero if the EXPORT_SYMBOL isn't there.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] unexport __print_symbol
@ 2005-03-04 0:49 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-03-04 0:49 UTC (permalink / raw)
To: linux-kernel
I didn't find any possible modular usage in the kernel.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c.old 2005-03-04 00:49:34.000000000 +0100
+++ linux-2.6.11-rc5-mm1-full/kernel/kallsyms.c 2005-03-04 00:49:49.000000000 +0100
@@ -408,4 +408,3 @@
}
__initcall(kallsyms_init);
-EXPORT_SYMBOL(__print_symbol);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-04-25 23:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-15 15:10 [2.6 patch] unexport __print_symbol Adrian Bunk
2005-04-23 23:35 ` Andrew Morton
2005-04-25 23:02 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-03-04 0:49 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox