From: Daniel Phillips <phillips@istop.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: David Teigland <teigland@redhat.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 1a/7] dlm: core locking
Date: Tue, 26 Apr 2005 01:10:00 -0400 [thread overview]
Message-ID: <200504260110.01115.phillips@istop.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0504252242510.2941@dragon.hyggekrogen.localhost>
On Monday 25 April 2005 17:17, Jesper Juhl wrote:
> > + int error = -ENOMEM, last_len, count = 0;
>
> Wouldn't
> int error = -ENOMEM;
> int last_len;
> int count = 0;
> be a bit more readable?
The rest of your nits are fine, upstanding nits, but this one seems a little
extreme :-)
Regards,
Daniel
next prev parent reply other threads:[~2005-04-26 5:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 16:57 [PATCH 1a/7] dlm: core locking David Teigland
2005-04-25 17:40 ` Nish Aravamudan
2005-04-25 21:17 ` Jesper Juhl
2005-04-26 5:10 ` Daniel Phillips [this message]
2005-04-26 8:43 ` David Teigland
2005-04-25 22:46 ` Pavel Machek
2005-04-27 14:48 ` Paul Jackson
2005-04-27 21:41 ` Mark Fasheh
2005-04-28 2:41 ` Daniel Phillips
2005-04-28 12:21 ` Lars Marowsky-Bree
2005-04-29 8:05 ` Daniel Phillips
2005-04-28 3:45 ` David Teigland
2005-04-28 13:48 ` Stephen C. Tweedie
2005-04-28 17:19 ` Joel Becker
2005-04-29 8:10 ` Daniel Phillips
2005-04-29 21:52 ` Mark Fasheh
2005-04-30 0:50 ` Daniel Phillips
2005-04-28 19:21 ` Mark Fasheh
2005-04-29 5:56 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504260110.01115.phillips@istop.com \
--to=phillips@istop.com \
--cc=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox