public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>
Subject: [PATCH 0/5] Misc driver core changes (constness)
Date: Tue, 26 Apr 2005 02:29:03 -0500	[thread overview]
Message-ID: <200504260229.03866.dtor_core@ameritech.net> (raw)

Hi,

It all started when code like this:

static const char driver_name = "blah";
static struct device_driver {
	.name = driver_name,
};

would give me compiler warning about removing constness because driver
core has "name" fields drclared simply as "char *". I think it is a good
idea to have them as "const char *" since whoever accesses them should
not try to change them.

01-hotplug-use-kobject-name.patch
  - kobject_hotplug should use kobject_name() instead of
    accessing kobj->name directly since for objects with
    long names it can contain garbage.

02-sysfs-link-constness.patch
  - make sysfs_{create|remove}_link to take const char * name.

03-kobject-const-name.patch
  - make kobject's name const char * since users should not
    attempt to change it (except by calling kobject_rename).

04-kset-name-const.patch
  - change name() method in kset_hiotplug_ops return const char *
    since users shoudl not try to modify returned data.

05-driver-const-name.patch
  - change driver's, bus's, class's and platform device's names
    to be const char * so one can use const char *drv_name = "asdfg";
    when initializing structures.
    Also kill couple of whitespaces.

Please consider for inclusion.

-- 
Dmitry

             reply	other threads:[~2005-04-26  7:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-26  7:29 Dmitry Torokhov [this message]
2005-04-26  7:29 ` [PATCH 1/5] kobject_hotplug() should use kobject_name() Dmitry Torokhov
2005-04-26  7:31 ` [PATCH 2/5] sysfs_{create|remove}_link should take const char * Dmitry Torokhov
2005-04-26  7:32 ` [PATCH 3/5] Make kobject's name be " Dmitry Torokhov
2005-04-26  7:32 ` [PATCH 4/5] kset_hotplug_ops->name shoudl return " Dmitry Torokhov
2005-04-26  7:34 ` [PATCH 5/5] make driver's name be " Dmitry Torokhov
2005-04-28  7:00 ` [PATCH 0/5] Misc driver core changes (constness) Greg KH
2005-04-29  5:58   ` [PATCH 6/5] Make attributes names const char * Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200504260229.03866.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox