From: Greg KH <greg@kroah.com>
To: Adam Belay <ambx1@neo.rr.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Pavel Machek <pavel@ucw.cz>, Amit Gud <gud@eth.net>,
Alan Stern <stern@rowland.harvard.edu>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, Andrew Morton <akpm@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>,
cramerj@intel.com,
USB development list <linux-usb-devel@lists.sourceforge.net>
Subject: Re: [linux-usb-devel] Re: [PATCH] PCI: Add pci shutdown ability
Date: Mon, 25 Apr 2005 23:44:51 -0700 [thread overview]
Message-ID: <20050426064450.GD5372@kroah.com> (raw)
In-Reply-To: <20050426063328.GD3951@neo.rr.com>
On Tue, Apr 26, 2005 at 02:33:28AM -0400, Adam Belay wrote:
> On Tue, Apr 26, 2005 at 01:39:20PM +1000, Benjamin Herrenschmidt wrote:
> >
> > > I believe it should just do suspend(PMSG_SUSPEND) before system
> > > shutdown. If you think distintion between shutdown and suspend is
> > > important (I am not 100% convinced it is), we can just add flag
> > > saying "this is system shutdown".
> > >
> > > Actually this patch should be in the queue somewhere... We had it in
> > > suse trees for a long time, and IMO it can solve problem easily.
> >
> > I think we probably want a distinct state for shutdown ...
>
> Yes, it's possible we do. I'm not sure what every platform requires. The
> question is should we make this change to pm_message_t in the short term?
> "->shutdown", even though incorrect, seems to fill this role.
>
> Greg, have you seen shutdown methods doing anything special other than
> standard "->suspend" stuff?
Don't know, never looked. Try looking at the system and platform
drivers, I think those are the only ones that have that callback hooked
up right now.
thanks,
greg k-h
prev parent reply other threads:[~2005-04-26 6:47 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44L0.0504251128070.5751-100000@iolanthe.rowland.org>
[not found] ` <SVLXCHCON1syWVLEFN00000099e@SVLXCHCON1.enterprise.veritas.com>
[not found] ` <20050425182951.GA23209@kroah.com>
[not found] ` <20050425185113.GC23209@kroah.com>
2005-04-25 19:06 ` [PATCH] PCI: Add pci shutdown ability Greg KH
2005-04-25 19:23 ` Jeff Garzik
2005-04-25 20:07 ` Greg KH
2005-04-25 20:11 ` Adam Belay
2005-04-25 19:45 ` Alexander Nyberg
2005-04-25 20:12 ` Greg KH
2005-04-26 3:59 ` Benjamin Herrenschmidt
2005-04-25 20:14 ` Alan Stern
2005-04-25 20:52 ` Alexander Nyberg
2005-04-25 21:12 ` Alan Stern
2005-04-26 15:49 ` Grant Grundler
2005-04-26 16:04 ` Alan Stern
2005-04-26 16:37 ` Grant Grundler
2005-04-26 17:14 ` Alan Stern
2005-04-26 17:41 ` Grant Grundler
2005-05-11 5:33 ` Vivek Goyal
2005-05-11 14:38 ` Alan Stern
2005-04-25 21:58 ` Andrew Morton
2005-04-25 22:13 ` Dave Jones
2005-04-25 23:23 ` Adam Belay
2005-04-26 4:32 ` Benjamin Herrenschmidt
2005-04-26 6:23 ` Adam Belay
2005-04-26 7:14 ` [linux-pm] " Nigel Cunningham
2005-04-26 9:16 ` Pavel Machek
2005-04-26 9:41 ` Pavel Machek
2005-04-26 3:52 ` Benjamin Herrenschmidt
2005-04-26 15:14 ` Alan Stern
2005-04-26 9:39 ` Pavel Machek
2005-04-26 17:50 ` Dave Jones
2005-04-26 20:23 ` Pavel Machek
2005-04-26 3:45 ` Benjamin Herrenschmidt
2005-04-26 15:11 ` Alan Stern
2005-04-26 16:01 ` Alexander Nyberg
2005-04-26 15:41 ` Grant Grundler
2005-04-26 16:07 ` Richard B. Johnson
2005-04-26 16:19 ` Grant Grundler
2005-04-26 17:12 ` Alan Stern
2005-04-26 17:19 ` Lee Revell
2005-04-25 20:08 ` Adam Belay
2005-04-25 20:19 ` Greg KH
2005-04-25 20:24 ` Adam Belay
2005-04-25 20:42 ` Pavel Machek
2005-04-25 20:55 ` Adam Belay
2005-04-25 21:06 ` Pavel Machek
2005-04-26 4:30 ` Benjamin Herrenschmidt
2005-04-26 16:12 ` Grant Grundler
2005-04-26 13:44 ` [linux-usb-devel] " David Brownell
2005-04-26 21:15 ` Pavel Machek
2005-04-25 21:00 ` Greg KH
2005-04-25 21:13 ` Pavel Machek
2005-04-26 3:41 ` Benjamin Herrenschmidt
2005-04-26 10:11 ` Pavel Machek
2005-04-25 21:13 ` [linux-usb-devel] " David Brownell
2005-04-26 3:39 ` Benjamin Herrenschmidt
2005-04-26 6:33 ` Adam Belay
2005-04-26 6:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050426064450.GD5372@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=benh@kernel.crashing.org \
--cc=cramerj@intel.com \
--cc=gud@eth.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=pavel@ucw.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox