Re: VM86 interrupt emulation breakage and FIXes for 2.6.x kernel series

Linus Torvalds
2004-12-11T04:22:11Z

On Sat, 11 Dec 2004, Alan Cox wrote:
>
> On Sad, 2004-12-11 at 01:23, Linus Torvalds wrote:
> > > Until the 10,000th event it actually seems to work rather happily
> > > without that change.
> >
> > I suspect you never tried the level-triggered case.
>
> Level triggered has never been supported.

So? You want it to lock up the machine?

Alan, what _are_ you arguing about? That "disable_irq()" is absolutely
rquired, because:
- not having it locks up the machine if the irq happens to be level.
- not having it means that the "enable_irq()" that happens when the irq
is reported to user space is unbalanced.

> Putting a single disable_irq in doesn't change the fact it doesn't work
> because the IRQ is never re-enabled.

Did you actually test the code? Did you ever _look_ at it?

Linus