public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
To: linux-kernel@vger.kernel.org,
	Linux ARM Kernel list  <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: [2.6.7.11, BUG] spin_lock_irqsave() unsafe for use with FIQ and no spin_lock_localsave() exists
Date: Tue, 26 Apr 2005 17:24:48 +0100	[thread overview]
Message-ID: <20050426162448.GD8817@lkcl.net> (raw)

like the subject says.

i utilised spin_lock_irqsave() with a FIQ handler, expecting to be able
to do this:

	spin_lock_irqsave(...)
	local_fiq_disable()
	spin_lock_restoreflags(...)

aaaannnd it caused some weirdo behaviour - not surprisingly because
spin_lock_irqsave() calls local_irq_save() which ONLY saves the
interrupt handler flags - NOT the FIQ handler flags.

a spin_lock_saveflags() which does exactly what spin_lock_irqsave() does
except it calls local_irq_save would be _greatly_ appreciated.

in linux/spinlock.h.

because i'm having to #define one anyway.

tia.

l.

-- 
--
<a href="http://lkcl.net">http://lkcl.net</a>
--

                 reply	other threads:[~2005-04-26 16:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050426162448.GD8817@lkcl.net \
    --to=lkcl@lkcl.net \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox