Re: [PATCH][RFC] Linux VM hooks for advanced RDMA NICs

Jesper Juhl
2005-04-26T16:54:44Z

On Tue, 26 Apr 2005, David Addison wrote:

> Hi,
> here is a patch we use to integrate the Quadrics NICs into the Linux kernel.
<snip>

A few small comments below.

>
> +static inline void
> +ioproc_release(struct mm_struct *mm)
> +{

Return types on same line as function name makes grep'ing a lot
easier/nicer.

Here's the example from Documentation/CodingStyle :

int function(int x)
{
body of function
}

<snip>
> +/* ! CONFIG_IOPROC so make all hooks empty */
> +
> +#define ioproc_release(mm) do { } while (0)
> +
> +#define ioproc_sync_range(vma, start, end) do { } while (0)
> +
> +#define ioproc_invalidate_range(vma, start,end) do { } while (0)
> +
> +#define ioproc_update_range(vma, start, end) do { } while (0)
> +
> +#define ioproc_change_protection(vma, start, end, prot) do { } while (0)
> +
> +#define ioproc_sync_page(vma, addr) do { } while (0)
> +
> +#define ioproc_invalidate_page(vma, addr) do { } while (0)
> +
> +#define ioproc_update_page(vma, addr) do { } while (0)
> +
Why all these blank lines between each define? Seems like just a waste of
screen space to me.

--
Jesper Juhl