From: Domen Puncer <domen@coderock.org>
To: David Teigland <teigland@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 1b/7] dlm: core locking
Date: Wed, 27 Apr 2005 14:33:40 +0200 [thread overview]
Message-ID: <20050427123340.GB18533@nd47.coderock.org> (raw)
In-Reply-To: <20050425165826.GB11938@redhat.com>
One thing I noticed (besides some trailing whitespace):
On 26/04/05 00:58 +0800, David Teigland wrote:
> + if (!r->res_lvbptr)
> + r->res_lvbptr = allocate_lvb(r->res_ls);
> +
> + if (!r->res_lvbptr)
> + return;
This suggests allocate_lvb can fail.
> +
> + memcpy(r->res_lvbptr, lkb->lkb_lvbptr, DLM_LVB_LEN);
...
However...
> +
> + if (!r->res_lvbptr)
> + r->res_lvbptr = allocate_lvb(r->res_ls);
> +
> + memcpy(r->res_lvbptr, lkb->lkb_lvbptr, DLM_LVB_LEN);
So... can it fail?
Domen
next prev parent reply other threads:[~2005-04-27 12:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 16:58 [PATCH 1b/7] dlm: core locking David Teigland
2005-04-25 18:34 ` Nikita Danilov
2005-04-25 20:44 ` Daniel Phillips
2005-04-25 22:27 ` Nikita Danilov
2005-04-26 1:34 ` Daniel Phillips
2005-04-25 20:41 ` Jesper Juhl
2005-04-26 5:00 ` Daniel Phillips
2005-04-25 21:54 ` Steven Dake
2005-04-26 5:49 ` David Teigland
2005-04-26 17:40 ` Steven Dake
2005-04-26 22:24 ` Daniel Phillips
2005-04-26 23:04 ` Steven Dake
2005-04-27 0:53 ` Daniel Phillips
2005-04-27 1:50 ` Steven Dake
2005-04-27 4:21 ` Daniel Phillips
2005-04-27 3:02 ` David Teigland
2005-04-27 13:41 ` Lars Marowsky-Bree
2005-04-27 14:26 ` David Teigland
2005-04-28 12:33 ` Lars Marowsky-Bree
2005-04-28 16:39 ` Daniel McNeil
2005-04-28 16:45 ` Lars Marowsky-Bree
2005-04-29 8:25 ` Daniel Phillips
2005-05-02 20:45 ` Lars Marowsky-Bree
2005-05-02 23:23 ` Daniel Phillips
2005-04-29 4:01 ` David Teigland
2005-04-29 22:58 ` Daniel McNeil
2005-04-30 4:29 ` David Teigland
2005-04-30 9:09 ` Daniel Phillips
2005-04-30 10:32 ` Lars Marowsky-Bree
2005-04-30 11:12 ` Daniel Phillips
2005-05-02 20:51 ` Lars Marowsky-Bree
2005-05-02 22:21 ` Daniel Phillips
2005-05-05 12:25 ` Stephen C. Tweedie
2005-05-05 12:40 ` copy_to_user question linux
2005-05-05 13:13 ` Richard B. Johnson
2005-05-05 19:29 ` [PATCH 1b/7] dlm: core locking Daniel Phillips
2005-04-28 2:52 ` Daniel Phillips
2005-04-28 12:37 ` Lars Marowsky-Bree
2005-04-28 23:43 ` Daniel Phillips
2005-04-28 6:49 ` Daniel Phillips
2005-04-28 12:55 ` Lars Marowsky-Bree
2005-04-29 0:26 ` Daniel Phillips
2005-04-29 2:52 ` David Teigland
2005-04-29 3:49 ` Daniel Phillips
2005-05-02 21:00 ` Lars Marowsky-Bree
2005-05-03 2:54 ` David Teigland
2005-04-27 12:33 ` Domen Puncer [this message]
2005-04-27 13:30 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050427123340.GB18533@nd47.coderock.org \
--to=domen@coderock.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox