Re: 2.6.11.7 kernel panic on boot on AMD64

Andi Kleen
2005-04-29T14:32:24Z

On Fri, Apr 29, 2005 at 12:06:02PM +0200, Alexander Nyberg wrote:
> >
> > I'm trying to install linux on an HP DL385 but directly on boot I got
> > this kernel panic:
> >
> > http://www.puettmann.net/temp/panic.jpg
>
>

Hmm? saved_command_Line should have enough space to add a simple string.
It is a 1024bytes. Unless you already have a 1k command line it should
be quite ok.

Why do you think it is bogus?

> This is bogus appending stuff to the saved_command_line and at the same
> time in Rubens case it touches the late_time_init() which breakes havoc.

I dont agree with this patch.

-Andi

>
> Signed-off-by: Alexander Nyberg <alexn@telia.com>
>
> Index: linux-2.6/arch/x86_64/kernel/head64.c
> ===================================================================
> --- linux-2.6.orig/arch/x86_64/kernel/head64.c 2005-04-26 11:41:43.000000000 +0200
> +++ linux-2.6/arch/x86_64/kernel/head64.c 2005-04-29 11:57:46.000000000 +0200
> @@ -93,9 +93,6 @@
> #ifdef CONFIG_SMP
> cpu_set(0, cpu_online_map);
> #endif
> - /* default console: */
> - if (!strstr(saved_command_line, "console="))
> - strcat(saved_command_line, " console=tty0");
> s = strstr(saved_command_line, "earlyprintk=");
> if (s != NULL)
> setup_early_printk(s);
>
>