public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
	Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Cliff White <cliffw@osdl.org>, "Theodore Ts'o" <tytso@mit.edu>,
	"Randy.Dunlap" <rddunlap@osdl.org>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: [10/07] sparc: Fix PTRACE_CONT bogosity
Date: Wed, 27 Apr 2005 11:38:13 -0700	[thread overview]
Message-ID: <20050427183813.GV493@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050427171446.GA3195@kroah.com>

-stable review patch.  If anyone has any objections, please let us know.

------------------


SunOS aparently had this weird PTRACE_CONT semantic which
we copied.  If the addr argument is something other than
1, it sets the process program counter to whatever that
value is.

This is different from every other Linux architecture, which
don't do anything with the addr and data args.

This difference in particular breaks the Linux native GDB support
for fork and vfork tracing on sparc and sparc64.

There is no interest in running SunOS binaries using this weird
PTRACE_CONT behavior, so just delete it so we behave like other
platforms do.

From: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@osdl.org>
---

===== arch/sparc/kernel/ptrace.c 1.22 vs edited =====
--- 1.22/arch/sparc/kernel/ptrace.c	2005-03-13 15:29:55 -08:00
+++ edited/arch/sparc/kernel/ptrace.c	2005-04-13 22:37:33 -07:00
@@ -531,18 +531,6 @@
 			pt_error_return(regs, EIO);
 			goto out_tsk;
 		}
-		if (addr != 1) {
-			if (addr & 3) {
-				pt_error_return(regs, EINVAL);
-				goto out_tsk;
-			}
-#ifdef DEBUG_PTRACE
-			printk ("Original: %08lx %08lx\n", child->thread.kregs->pc, child->thread.kregs->npc);
-			printk ("Continuing with %08lx %08lx\n", addr, addr+4);
-#endif
-			child->thread.kregs->pc = addr;
-			child->thread.kregs->npc = addr + 4;
-		}
 
 		if (request == PTRACE_SYSCALL)
 			set_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
===== arch/sparc64/kernel/ptrace.c 1.24 vs edited =====
--- 1.24/arch/sparc64/kernel/ptrace.c	2005-02-10 19:06:44 -08:00
+++ edited/arch/sparc64/kernel/ptrace.c	2005-04-16 20:52:21 -07:00
@@ -514,25 +563,6 @@
 			pt_error_return(regs, EIO);
 			goto out_tsk;
 		}
-		if (addr != 1) {
-			unsigned long pc_mask = ~0UL;
-
-			if ((child->thread_info->flags & _TIF_32BIT) != 0)
-				pc_mask = 0xffffffff;
-
-			if (addr & 3) {
-				pt_error_return(regs, EINVAL);
-				goto out_tsk;
-			}
-#ifdef DEBUG_PTRACE
-			printk ("Original: %016lx %016lx\n",
-				child->thread_info->kregs->tpc,
-				child->thread_info->kregs->tnpc);
-			printk ("Continuing with %016lx %016lx\n", addr, addr+4);
-#endif
-			child->thread_info->kregs->tpc = (addr & pc_mask);
-			child->thread_info->kregs->tnpc = ((addr + 4) & pc_mask);
-		}
 
 		if (request == PTRACE_SYSCALL) {
 			set_tsk_thread_flag(child, TIF_SYSCALL_TRACE);



  parent reply	other threads:[~2005-04-27 18:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-27 17:14 [00/07] -stable review Greg KH
2005-04-27 17:15 ` [01/07] uml: add nfsd syscall when nfsd is modular Greg KH
2005-04-27 16:33   ` Alan Cox
2005-04-27 17:46     ` Chris Wright
2005-04-27 17:23       ` Alan Cox
2005-04-27 18:47         ` Chris Wright
2005-04-29  4:16           ` Greg KH
2005-04-27 17:16 ` [02/07] [fix Bug 4395] modprobe bttv freezes the computer Greg KH
2005-04-27 17:16 ` [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers Greg KH
2005-04-27 19:41   ` Dmitry Torokhov
2005-04-27 19:49     ` Dmitry Torokhov
2005-04-28  5:47   ` Dmitry Torokhov
2005-04-27 17:16 ` [04/07] partitions/msdos.c fix Greg KH
2005-04-27 20:34   ` Andries Brouwer
2005-04-27 20:49     ` Erik Tews
2005-04-27 22:08       ` Andries Brouwer
2005-04-27 20:35   ` Pavel Machek
2005-04-27 17:16 ` [05/07] [PATCH] Fix reproducible SMP crash in security/keys/key.c Greg KH
2005-04-27 17:16 ` [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc Greg KH
2005-04-27 16:38   ` Alan Cox
2005-04-27 18:26     ` Greg KH
2005-04-27 17:51       ` Alan Cox
2005-04-28  5:43     ` Kai Makisara
2005-04-28 12:49       ` Arjan van de Ven
2005-04-28 13:21       ` Alan Cox
2005-04-29  4:20         ` Greg KH
2005-04-29 20:16           ` Alan Cox
2005-04-29 20:38             ` Greg KH
2005-04-30  5:52               ` Kai Makisara
2005-04-30  5:10                 ` Greg KH
2005-04-30  8:10                   ` Kai Makisara
2005-04-27 17:17 ` [07/07] uml: quick fix syscall table Greg KH
2005-04-27 18:26 ` [00/07] -stable review Chris Wright
2005-04-27 18:31 ` [08/07] sparc64: Fix copy_siginfo_to_user32() Chris Wright
2005-04-27 18:35 ` [09/07] sparc64: use message queue compat syscalls Chris Wright
2005-04-27 18:38 ` Chris Wright [this message]
2005-04-27 17:53   ` [10/07] sparc: Fix PTRACE_CONT bogosity Alan Cox
2005-04-28  0:13 ` [00/07] -stable review Nick Piggin
2005-04-28  1:33   ` Chris Wright
2005-04-28  1:43     ` Nick Piggin
2005-04-29  4:14       ` Rules about the -stable tree Greg KH
2005-04-28  1:51     ` [00/07] -stable review Zwane Mwaikambo
2005-04-28  1:51       ` Nick Piggin
2005-04-28  1:54       ` Justin M. Forbes
2005-04-28  6:49 ` Gregor Jasny
2005-04-28  6:59   ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050427183813.GV493@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=chuckw@quantumlinux.com \
    --cc=cliffw@osdl.org \
    --cc=davem@davemloft.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox