From: Andrew Morton <akpm@osdl.org>
To: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Cc: linux-kernel@vger.kernel.org, ian.pratt@cl.cam.ac.uk
Subject: Re: [PATCH 3/6][XEN][x86] Rename usermode macro
Date: Wed, 27 Apr 2005 19:43:43 -0700 [thread overview]
Message-ID: <20050427194343.3d3ffe2f.akpm@osdl.org> (raw)
In-Reply-To: <20050426112604.GC26614@snarc.org>
Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk> wrote:
>
> The following patch rename user_mode to user_mode_vm and add a user_mode macro
> similar to the x86-64 one.
Why didn't your testing pick up the x86_64 build error?
arch/x86_64/oprofile/built-in.o(.text+0x1d09): In function `x86_backtrace':
arch/x86_64/oprofile/../../i386/oprofile/backtrace.c:94: undefined reference to `user_mode_vm'
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
include/asm-x86_64/ptrace.h | 1 +
1 files changed, 1 insertion(+)
diff -puN include/asm-x86_64/ptrace.h~xen-x86-rename-usermode-macro-fix include/asm-x86_64/ptrace.h
--- 25/include/asm-x86_64/ptrace.h~xen-x86-rename-usermode-macro-fix 2005-04-27 18:22:12.000000000 -0700
+++ 25-akpm/include/asm-x86_64/ptrace.h 2005-04-27 18:22:12.000000000 -0700
@@ -82,6 +82,7 @@ struct pt_regs {
#if defined(__KERNEL__) && !defined(__ASSEMBLY__)
#define user_mode(regs) (!!((regs)->cs & 3))
+#define user_mode_vm(regs) user_mode(regs)
#define instruction_pointer(regs) ((regs)->rip)
extern unsigned long profile_pc(struct pt_regs *regs);
void signal_fault(struct pt_regs *regs, void __user *frame, char *where);
_
next prev parent reply other threads:[~2005-04-28 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 10:38 "[PATCH Vincent Hanquez
2005-04-26 11:26 ` [PATCH 3/6][XEN][x86] Rename usermode macro Vincent Hanquez
2005-04-28 2:43 ` Andrew Morton [this message]
2005-04-28 14:39 ` Vincent Hanquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050427194343.3d3ffe2f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ian.pratt@cl.cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.hanquez@cl.cam.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox