From: Greg KH <greg@kroah.com>
To: Kylene Hall <kjhall@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10 of 12] Fix Tpm driver -- sysfs owernship changes
Date: Wed, 27 Apr 2005 21:19:16 -0700 [thread overview]
Message-ID: <20050428041915.GD9723@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504271645170.3929@jo.austin.ibm.com>
On Wed, Apr 27, 2005 at 05:19:03PM -0500, Kylene Hall wrote:
> - device_remove_file(&pci_dev->dev, &dev_attr_pubek);
> - device_remove_file(&pci_dev->dev, &dev_attr_pcrs);
> - device_remove_file(&pci_dev->dev, &dev_attr_caps);
> + for (i = 0; i < TPM_NUM_ATTR; i++)
> + device_remove_file(&pci_dev->dev, &chip->vendor->attr[i]);
Use an attribute group, instead of this. That will allow you to get
rid of the TPM_NUM_ATTR value, and this looney macro:
> +#define TPM_DEVICE_ATTRS { \
> + __ATTR(pubek, S_IRUGO, tpm_show_pubek, NULL), \
> + __ATTR(pcrs, S_IRUGO, tpm_show_pcrs, NULL), \
> + __ATTR(caps, S_IRUGO, tpm_show_caps, NULL), \
> + __ATTR(cancel, S_IWUSR | S_IWGRP, NULL, tpm_store_cancel) }
thanks,
greg k-h
next prev parent reply other threads:[~2005-04-28 4:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 22:19 [PATCH 10 of 12] Fix Tpm driver -- sysfs owernship changes Kylene Hall
2005-04-28 4:19 ` Greg KH [this message]
2005-04-28 20:40 ` Kylene Hall
2005-04-29 4:28 ` Greg KH
2005-04-29 16:30 ` Kylene Jo Hall
2005-04-29 16:38 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-05-05 19:11 Kylene Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050428041915.GD9723@kroah.com \
--to=greg@kroah.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox