Re: [PATCH 1b/7] dlm: core locking

Nikita Danilov
2005-04-25T18:34:50Z

David Teigland writes:
>
> The core dlm functions. Processes dlm_lock() and dlm_unlock() requests.

[...]

> +
> +static int is_remote(struct dlm_rsb *r)
> +{
> + DLM_ASSERT(r->res_nodeid >= 0, dlm_print_rsb(r););
> + return r->res_nodeid ? TRUE : FALSE;
> +}

This can be simply

return r->res_nodeid;

> +
> +static int is_master(struct dlm_rsb *r)
> +{
> + return r->res_nodeid ? FALSE : TRUE;
> +}

This duplicates dlm_is_master() for no obvious reason.

> +
> +int dlm_is_master(struct dlm_rsb *r)
> +{
> + return r->res_nodeid ? FALSE : TRUE;
> +}

This can be simply

return !r->res_nodeid;

Nikita.