Re: [PATCH 1b/7] dlm: core locking

Nikita Danilov
2005-04-25T22:28:17Z

Daniel Phillips writes:
> Hi Nikita,
>
> On Monday 25 April 2005 14:34, you wrote:
> > > +
> > > +static int is_remote(struct dlm_rsb *r)
> > > +{
> > > + DLM_ASSERT(r->res_nodeid >= 0, dlm_print_rsb(r););
> > > + return r->res_nodeid ? TRUE : FALSE;
> > > +}
> >
> > This can be simply
> >
> > return r->res_nodeid;
>
> Not quite the same. Perhaps you meant:
>
> return !!r->res_nodeid;

Strictly speaking yes (assuming TRUE is defined as 1), but name
is_remote() implies usages like

if (is_remote(r)) {
do_something();
}

in such contexts !! is not necessary.

>
> Regards,
>
> Daniel

Nikita.