Re: [PATCH 3/4] ppc64: Add driver for BPA iommu

[Arnd Bergmann <arnd@arndb.de>]

On Freedag 29 April 2005 07:36, Olof Johansson wrote:
> On Fri, Apr 29, 2005 at 06:35:43AM +0200, Arnd Bergmann wrote:
>>
> Anyhow, enum or #define, it should be moved to bpa_iommu.h.

I don't interface with any other files, so I prefer to have
everything in one file here. If there is anyone else who
agrees with you on moving this into a separate file, I don't
mind doing that.

> User or developer error? I thought it was a developer one, and a quite
> specialized one at that. Either way, there's already a primitive that
> can be used instead of making your own: BUILD_BUG_ON().

Right. I had forgotten about that, thanks.
 
> > Yes, but it seems to contradict the specs...
> 
> A comment to that effect could be nice.

Ok, I'll change that.

> > This comes from a graphical representation in the specs. I'll add a comment
> > to point to that image.
> 
> I guess it'd be a bit much information to just add in a comment, but for
> readability that's probably the best way to go.  Not many people have
> the specs, but on the other hand if you're messing around with this code
> then chances are you have them.

The picture should be in the parts that we are working on getting public.

> I don't know what the status is for a release of public specifications,
> but if they're not available then people will be looking to learn from
> the implementation and the documentation around it instead.

There will be a supplement to Book 1-3 of PowerPC AS that is going to
be public. Book 4 is rarely needed and the chances of publishing that
are not as good.

Thanks,

	Arnd <><