public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: YhLu <YhLu@tyan.com>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: x86-64 dual core mapping
Date: Fri, 29 Apr 2005 17:56:30 -0700	[thread overview]
Message-ID: <20050429175629.A23904@unix-os.sc.intel.com> (raw)
In-Reply-To: <3174569B9743D511922F00A0C943142309B079F4@TYANWEB>; from YhLu@tyan.com on Thu, Apr 28, 2005 at 12:49:42PM -0700

On Thu, Apr 28, 2005 at 12:49:42PM -0700, YhLu wrote:
> Please refer to my patch about that.
> 
> --- smpboot.o.c 2005-04-28 13:00:03.611550488 -0700
> +++ smpboot.c   2005-04-28 12:59:27.151093320 -0700
> @@ -652,7 +652,7 @@
>                 int i;
>                 if (smp_num_siblings > 1) {
>                         for_each_online_cpu (i) {
> -                               if (cpu_core_id[cpu] == cpu_core_id[i]) {
> +                               if (cpu_to_node[cpu] == cpu_to_node[i]) {
>                                         siblings++;
>                                         cpu_set(i, cpu_sibling_map[cpu]);
>                                 }

This patch is wrong. It will break Intel systems and I think it is also not 
the correct fix for the systems you are trying to fix.

Please don't do this.

thanks,
suresh

  reply	other threads:[~2005-04-30  0:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-28 19:49 x86-64 dual core mapping YhLu
2005-04-30  0:56 ` Siddha, Suresh B [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-05-09 21:24 YhLu
2005-05-04  0:18 YhLu
2005-05-04 13:18 ` Andi Kleen
2005-05-03 23:35 YhLu
2005-05-02 21:01 YhLu
2005-05-03 14:25 ` Andi Kleen
2005-05-02 19:41 YhLu
2005-05-02 20:18 ` Andi Kleen
2005-04-28 18:55 YhLu
2005-04-22  2:38 YhLu
2005-05-02 17:02 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050429175629.A23904@unix-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=YhLu@tyan.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox